-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rails 6.1 support #15
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Time to move to CircleCI my friend!
Appraisals
Outdated
@@ -3,5 +3,5 @@ appraise 'activerecord-5' do | |||
end | |||
|
|||
appraise 'activerecord-6' do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we test with both 6.0 and 6.1?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point. I updated the appraisals to reflect it now
Pull Request Test Coverage Report for Build 117
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Travis config needs to be updated for your appraisal changes.
Appraisals
Outdated
@@ -1,7 +1,11 @@ | |||
appraise 'activerecord-5' do | |||
appraise 'activerecord_5_2' do | |||
gem 'activerecord', '< 6.0.0' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This better shows what we're trying to test:
gem 'activerecord', '< 6.0.0' | |
gem 'activerecord', '~> 5.2.0' |
Appraisals
Outdated
appraise 'activerecord-6' do | ||
gem 'activerecord', '< 6.1' | ||
appraise 'activerecord_6_0' do | ||
gem 'activerecord', '< 6.1.0' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This better shows what we're trying to test:
gem 'activerecord', '< 6.1.0' | |
gem 'activerecord', '~> 6.0.0' |
Appraisals
Outdated
end | ||
|
||
appraise 'activerecord_6_1' do | ||
gem 'activerecord', '< 6.2.0' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This better shows what we're trying to test:
gem 'activerecord', '< 6.2.0' | |
gem 'activerecord', '~> 6.1.0' |
Only 1 rename and 1 deprecation, both in the same class.
@jturkel you are prime. Travis is taking forever to run the build but ran the tests locally.