Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import tree_reject from salsify_kafka #1

Merged
merged 5 commits into from
Mar 28, 2019

Conversation

ecopoesis
Copy link
Contributor

Extract tree_reject from salsify_kafka so I can use it in salsify_graphql-server.

@ecopoesis ecopoesis requested a review from jturkel March 28, 2019 18:43
Copy link
Member

@jturkel jturkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Might make sense to add some additional functionality in the future e.g. in place mutation (tree_reject!) or tree rejection via path (tree_reject(:a, :aa, :aaa)) but no need to do that now.

README.md Outdated
}
```

and `tree_reject` the Hash:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The following would more clearly demonstrate how to call the function:

hash.tree_reject({
  a: {
    aa: :aaa
  }
})

@ecopoesis ecopoesis merged commit a3d44d1 into master Mar 28, 2019
@ecopoesis ecopoesis deleted the feature/import-from-salsify-kafka branch March 28, 2019 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants