Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] salt_aborted metric lacks a state label #26

Closed
nicholasmhughes opened this issue Feb 20, 2024 · 0 comments · Fixed by #27
Closed

[BUG] salt_aborted metric lacks a state label #26

nicholasmhughes opened this issue Feb 20, 2024 · 0 comments · Fixed by #27
Assignees
Labels
bug Something isn't working

Comments

@nicholasmhughes
Copy link
Member

Description
The salt_aborted metric needs to have a state label applied to prevent conflicts when multiple files are generated for the prometheus textfile collector.

$ grep ^salt_aborted /var/lib/node_exporter/textfile_collector/salt-*
/var/lib/node_exporter/textfile_collector/salt-stateone.prom
5:salt_aborted 0.0

/var/lib/node_exporter/textfile_collector/salt-statetwo.prom
5:salt_aborted 0.0

/var/lib/node_exporter/textfile_collector/salt-highstate.prom
5:salt_aborted 0.0

that's considered a duplicate and the textfile collector complains, whereas all the other metrics are of the form salt_states_succeeded{state="highstate"} 2.0 for comparison

Expected behavior
generated files should not create errors due to conflicts of metrics

@nicholasmhughes nicholasmhughes added the bug Something isn't working label Feb 20, 2024
@nicholasmhughes nicholasmhughes self-assigned this Feb 20, 2024
nicholasmhughes added a commit to nicholasmhughes/saltext-prometheus that referenced this issue Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant