Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Tests to Cover a Non-Blank hashPrefix Value #39

Closed
davewoodward opened this issue Dec 19, 2016 · 0 comments
Closed

Add Tests to Cover a Non-Blank hashPrefix Value #39

davewoodward opened this issue Dec 19, 2016 · 0 comments

Comments

@davewoodward
Copy link
Contributor

Description

AngularJS 1.6 changed the default hashPrefix value to the bang symbol. As a result, we had to expose the hashPrefix through the configuration object to enable the consuming application to provide it.

davewoodward added a commit that referenced this issue Dec 20, 2016
cecilia-sanare pushed a commit that referenced this issue May 4, 2022
* fix: include hashPrefix configuration parameter

AngularJS 1.6.0 change the hashPrefix default to the bang operator.  To
support this as well as any other custom value that may be specified by
the application developer we chose to allow this to be specified in the
configuration object as part of the application initialization process.

* fix: linting errors

* feat: configurable token endpoint callback timeout

This closes #38 and closes #39.
cecilia-sanare pushed a commit that referenced this issue May 4, 2022
* fix: include hashPrefix configuration parameter

AngularJS 1.6.0 change the hashPrefix default to the bang operator.  To
support this as well as any other custom value that may be specified by
the application developer we chose to allow this to be specified in the
configuration object as part of the application initialization process.

* fix: linting errors

* feat: configurable token endpoint callback timeout

This closes #38 and closes #39.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant