add support for serializing parts of an element separately #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #153 +/- ##
==========================================
+ Coverage 93.71% 93.71% +<.01%
==========================================
Files 58 58
Lines 2401 2404 +3
Branches 407 408 +1
==========================================
+ Hits 2250 2253 +3
Misses 151 151
Continue to review full report at Codecov.
|
royra
reviewed
Sep 9, 2019
hadard
reviewed
Sep 9, 2019
| // If we got a single element, put it in an array because we need to wrap it with an empty block | ||
| const elemListOrValues = isElement(elementsOrValues) ? [elementsOrValues] : elementsOrValues | ||
|
|
||
| const body = _.isArray(elemListOrValues) |
There was a problem hiding this comment.
is it possible that elemListOrValues is not an array?
There was a problem hiding this comment.
yes, if we get Values (they are an object, not a list)
hadard
approved these changes
Sep 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature will be needed when we want to have iterative discover write only diffs to blueprints