SALTO-1155: Update jest version #1804
Conversation
|
build fails because of a yarn bug that was only fixed in yarn v2 (link) |
ori-moisis
dismissed
noamhammer’s stale review
Not done upgrading packages, the old jest version is still in the yarn.lock file
ori-moisis
force-pushed
the
update/jest
branch
2 times, most recently
from
f403cd4
to
785ff73
Compare
ori-moisis
force-pushed
the
update/jest
branch
from
785ff73
to
194f6fd
Compare
| - run: yarn | ||
| # Yarn has some random race-condition failures, trying multiple times seems to help | ||
| # when the source of the problem is yarn itself and not the packages | ||
| - run: yarn || yarn || yarn |
There was a problem hiding this comment.
will we always need this, or only until everything is upgraded?
There was a problem hiding this comment.
this is probably only relevant whenever we change any dependency (otherwise the first "yarn" would just do nothing an succeed, so the other two won't run)
I think we should leave it in though because I wouldn't want to re-discover this yarn bug every time we upgrade a package
| @@ -19,10 +19,18 @@ const deepMerge = require('../../build_utils/deep_merge') | |||
| module.exports = deepMerge( | |||
| require('../../eslintrc.js'), | |||
| { | |||
| overrides: [ | |||
There was a problem hiding this comment.
just out of curiosity, why was this change needed?
There was a problem hiding this comment.
because of the dynalite config file, because it is a .js file eslint wanted to lint it.
in the base eslint config we set a project for all files (that is probably a mistake, but I did not want to deal with that as part of this PR) but because this config .js file is not really a part of the project it made eslint fail.
This configuration override makes it so only .ts files will have the project attribute set.
btw - The project attribute is require only for lint rules that rely on types, I think we don't have any such rules enabled so it might be possible to get rid of this altogether, but again, didn't want to deal with that as part of this PR
Release Notes:
None