-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SALTO-5555: errors in fetch JSM forms #5873
SALTO-5555: errors in fetch JSM forms #5873
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⭐ ⭐ ⭐ ⭐ ⭐
Thank you for the very detailed commit comment. It made the review much easier.
I think the general concept is great, see my comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
I am approving, please look at the comments and most importantly the one about different types of errors
8a31e20
to
11eb971
Compare
In this PR I fixed the multiple errors in JSM Forms.
Additional context for reviewer
Currently, we are logging many errors related to failures in fetching JSM forms.
Example in oriSaltoTest:
In addition, I decreased the logs from Error to debug and added fetch warnings.
Important Note:
I will add tests after the initial review to ensure that my solution is acceptable.
Release Notes:
Jira adapter:
User Notifications:
Jira adapter: