-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SALTO-5643: Adding members in the order they are defined #5877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ori-moisis
reviewed
May 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
didn't finish reviewing the logic, but I think there are enough comments to do a round...
packages/workspace/src/workspace/nacl_files/nacl_file_update.ts
Outdated
Show resolved
Hide resolved
packages/workspace/src/workspace/nacl_files/nacl_file_update.ts
Outdated
Show resolved
Hide resolved
packages/workspace/src/workspace/nacl_files/nacl_file_update.ts
Outdated
Show resolved
Hide resolved
packages/workspace/src/workspace/nacl_files/nacl_file_update.ts
Outdated
Show resolved
Hide resolved
packages/workspace/src/workspace/nacl_files/nacl_file_update.ts
Outdated
Show resolved
Hide resolved
packages/workspace/src/workspace/nacl_files/nacl_file_update.ts
Outdated
Show resolved
Hide resolved
packages/workspace/src/workspace/nacl_files/nacl_file_update.ts
Outdated
Show resolved
Hide resolved
packages/workspace/src/workspace/nacl_files/nacl_file_update.ts
Outdated
Show resolved
Hide resolved
yelly
force-pushed
the
SALTO-5643
branch
3 times, most recently
from
May 15, 2024 11:27
8c22d70
to
37510ae
Compare
ori-moisis
reviewed
May 15, 2024
packages/workspace/src/workspace/nacl_files/nacl_file_update.ts
Outdated
Show resolved
Hide resolved
packages/workspace/src/workspace/nacl_files/nacl_file_update.ts
Outdated
Show resolved
Hide resolved
packages/workspace/src/workspace/nacl_files/nacl_file_update.ts
Outdated
Show resolved
Hide resolved
packages/workspace/src/workspace/nacl_files/nacl_file_update.ts
Outdated
Show resolved
Hide resolved
packages/workspace/src/workspace/nacl_files/nacl_file_update.ts
Outdated
Show resolved
Hide resolved
packages/workspace/src/workspace/nacl_files/nacl_file_update.ts
Outdated
Show resolved
Hide resolved
packages/workspace/test/workspace/nacl_files/nacl_file_update.test.ts
Outdated
Show resolved
Hide resolved
packages/workspace/test/workspace/nacl_files/nacl_file_update.test.ts
Outdated
Show resolved
Hide resolved
ori-moisis
approved these changes
May 22, 2024
packages/workspace/src/workspace/nacl_files/nacl_file_update.ts
Outdated
Show resolved
Hide resolved
packages/workspace/src/workspace/nacl_files/nacl_file_update.ts
Outdated
Show resolved
Hide resolved
packages/workspace/src/workspace/nacl_files/nacl_file_update.ts
Outdated
Show resolved
Hide resolved
packages/workspace/src/workspace/nacl_files/nacl_file_update.ts
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of adding new fields, annotations or values at the end of their parent in NaCl files, add them in the order they are defined in their parent object. This will ensure that members always show up in the same place in the NaCl if they are removed and added again.
Additional context for reviewer
Still need to add higher level tests, IMO it's cleaner to split into a separate PR.
Release Notes:
Core
User Notifications:
None.