SALTO-5915 Google ws - fix - roleAssignment deployment #5881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uri-Bar
force-pushed
the
SALTO-5915-google-ws-fix-role-assignment-deployment
branch
from
913cdc6
to
f113151
Compare
shir-reifenberg
approved these changes
May 14, 2024
There was a problem hiding this comment.
looks great! 👯
for next prs, I think it's better to split adapter changes from infra changes, and link each one to it's own ticket. It makes it easier to understand later why we done each change
Also, please update PR title to include info about the infra change 🙏
| const response = await singleClientCall(args) | ||
| return polling.checkStatus(response) ? response : undefined | ||
| } catch (e) { | ||
| if (polling.retryOnStatus?.includes(e.response?.status)) { |
There was a problem hiding this comment.
let's verify as well that ?
e instanceof clientUtils.HTTPError
| @@ -38,6 +38,7 @@ export type PollingArgs = { | |||
| interval: number | |||
| retries: number | |||
| checkStatus: (response: Response<ResponseValue | ResponseValue[]>) => boolean | |||
| retryOnStatus?: number[] | |||
There was a problem hiding this comment.
nit - maybe worth adding a comment about why this is needed and how it's different from checkStatus ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SALTO-5915 Google ws - fix - roleAssignment deployment
Additional context for reviewer
Release Notes:
none
User Notifications:
none