delegates: allocate VTable in heap #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jagobagascon
force-pushed
the
feature/alloc-vtable-in-the-heap
branch
from
e17a671
to
d40e892
Compare
The VTable is a field all WinRT types have and it is used to store pointers to all the class functions. This field is usually created by WinRT, but for delegates we need to provide our own VTable instance. We were previously using a Go struct pointer as our VTable, but Go structs can be randomly moved or GCed by the Go runtime, and since we are pasing the VTable to WinRT (out of the Go runtime), we were getting random invalid memory errors. This was addressed in a previous PR (#64) but somehow we missed this. fixes #94
jagobagascon
force-pushed
the
feature/alloc-vtable-in-the-heap
branch
from
d40e892
to
3fb5e41
Compare
glerchundi
approved these changes
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The VTable is a field all WinRT types have and it is used to store pointers to all the class functions. This field is usually created by WinRT, but for delegates we need to provide our own VTable instance.
We were previously using a Go struct pointer as our VTable, but Go structs can be randomly moved or GCed by the Go runtime, and since we are pasing the VTable to WinRT (out of the Go runtime), we were getting random invalid memory errors.
This was addressed in a previous PR (#64) but somehow we missed this.
fixes #94