Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure listen directive #106

Merged
merged 2 commits into from
Dec 24, 2015
Merged

Configure listen directive #106

merged 2 commits into from
Dec 24, 2015

Conversation

genuss
Copy link
Contributor

@genuss genuss commented Dec 24, 2015

Add listen directive to vhosts templates and remove ports.conf
This should also fix #33

gravyboat added a commit that referenced this pull request Dec 24, 2015
Configure listen directive
@gravyboat gravyboat merged commit 6f20861 into saltstack-formulas:master Dec 24, 2015
@gravyboat
Copy link
Contributor

Thanks.

@genuss genuss deleted the conf_ports branch December 25, 2015 11:08
@gravyboat
Copy link
Contributor

Thanks for pointing that out @jeffrysleddens, I hadn't considered that. @genuss do you want to see if you can introduce a patch? Or @jeffrysleddens if you're feeling up to it.

@genuss
Copy link
Contributor Author

genuss commented Feb 1, 2016

So you mean if you use salt only to install apache package but you don't use apache.vhosts state?
But how is that possible?

@jeffrysleddens
Copy link

Indeed we don't use the apache.vhosts state.

We only use the apache.debian_full state

Our state init.sls looks like this:

include:

  • apache.debian_full

And our pillar init.sls looks like this:

apache:
wwwdir: /srv/www
register-site:
autodiscover:
name: autodiscover
path:
salt://servers/server_name/files/etc/apache2/sites-available/autodiscover.conf
state: enabled
examportal:
name: examportal
path:
salt://servers/server_name/files/etc/apache2/sites-available/examportal.conf
state: enabled
... etc ...

This used to work perfectly. But now this state is broken because of the
missing ports.conf.

One solution/workaround I can think of is making it configurable in the
pillar whether to use the site wide ports.conf or not.

Or we could surround the file.absent block in debian_full.sls with a check
for the existance of the sites pillar:

{% if pillar['apache.sites'] is defined %}
/etc/apache2/ports.conf:
file.absent:
- require:
- pkg: apache
{% endif %}

On Mon, Feb 1, 2016 at 11:56 AM, genuss notifications@github.com wrote:

So you mean if you use salt only to install apache package but you don't
use apache.vhosts state?
But how is that possible?


Reply to this email directly or view it on GitHub
#106 (comment)
.

@genuss
Copy link
Contributor Author

genuss commented Feb 1, 2016

@jeffrysleddens, look at #113 please.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ability to configure listening ports
3 participants