Do not pass full apache context to vhost templates. #298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The full apache context variable can grow quite large if using multiple vhosts with SSL certificates. With 200 sites the apache variable is being rendered 200 times which resuls in observed renderer output of about 950MB... state.apply will result with MemoryErrors in such cases. This PR modifies the templating code to _only_ use a per site context and pass a trimmed down copy of the apache context instead of the full. Drive-By: Correct indentation for context variables. Drive-By: Remove duplicate map/apache functionality. Only use map.
|
Thanks @ixs all good. |
|
🎉 This PR is included in version 1.1.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The full apache context variable can grow quite large if using multiple
vhosts with SSL certificates.
With 200 sites the apache variable is being rendered 200 times which resuls
in observed renderer output of about 950MB...
state.apply will result with MemoryErrors in such cases.
This PR modifies the templating code to only use a per site context
and pass a trimmed down copy of the apache context instead of the full.
Drive-By: Correct indentation for context variables.
Drive-By: Remove duplicate map/apache functionality. Only use map.