repo change via major_version

[blbradley]

This allows users to install ElasticSearch 2.x or 5.x.

With this, users can't specify the exact version. I'm up creating something more flexible now or later.

Behavior

• no value or `2': as the formula works now
• 5: installs 5.x from new repo
• from 2 to 5: installs 5.x in place of 2.x, data upgraded (i think)
• from 5 to 2: service tries to start on every highstate (systemd)

[blbradley]

@martinhoefling @kpostrup ping!

I updated the top comment to reflect behavior of this one.

[danygielow]

Version 5.x introduced some more changes that have to be addressed:

The following list has been taken from PRs for the official ansible role elastic/ansible-elasticsearch#178 and elastic/ansible-elasticsearch#182

• plugin binary is now called elasticsearch-plugin
• Use log4j2.properties instead of logging.yml
  • https://www.elastic.co/guide/en/elasticsearch/reference/5.0/settings.html#logging
• Add jvm.options
  • https://www.elastic.co/guide/en/elasticsearch/reference/5.0/breaking_50_packaging.html#_jvm_options
• Use bootstrap.memory_lock instead of bootstrap.mlockall
  • https://www.elastic.co/guide/en/elasticsearch/reference/master/setup-configuration-memory.html#mlockall
• Get rid of work directory
  • Remove working directory elastic/elasticsearch#10672
• Executable does not accept -D anymore, replace with -E and -p - --help of executable
• Executable does not accept -- anymore, replace with -E
  • https://www.elastic.co/guide/en/elasticsearch/reference/5.0/breaking_50_settings_changes.html#_removed_using_double_dashes_to_configure_elasticsearch

[blbradley]

@danygielow Only bullet item four is directly managed by this formula. It would not be if I can get #12 merged.

[blbradley]

Even more importantly, #14 need to be merged before anything so I can show that both 2.x and 5.x work out of the box.

[aboe76]

@blbradley I have merged #14 what can I do to speed this up so the formula is usable with 5.x elastic search?

[blbradley]

@aboe76 I have tests for this I need to push, but I'm at a conference today.

[aboe76]

@blbradley, No Problem ping me tomorrow, and I help you merge some stuff in this formula.

[blbradley]

@aboe76 If you want to take a look at #12 and mentioned issues inside that would be great. But we need discussion before merging anything else.

[blbradley]

#12 is merged! Working on this now.

[blbradley]

@aboe76 I'm thinking that should cover it. Thanks for your reviews!

P.S. Don't forget to squash! 😁

[aboe76]

looks good and the test ran OK

[blbradley]

@jcockhren Yo! I know you were interested in this. We are done here!

[aboe76]

@blbradley this leaves #11 only todo, to make everybody happy.