Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add elasticsearch:add_repo pillar #36

Closed
wants to merge 1 commit into from

Conversation

cboltz
Copy link
Contributor

@cboltz cboltz commented Jun 5, 2017

There are setups where adding the elasticsearch repo is not wanted, and
in other cases (Distro != Debian or RedHat) it's even broken in
elasticsearch-formula.

Therefore add a pillar (add_repo) that allows to disable adding the repo.

add_repo defaults to True for backward compability.

CC @ccboltz @tampakrap

There are setups where adding the elasticsearch repo is not wanted, and
in other cases (Distro != Debian or RedHat) it's even broken in
elasticsearch-formula.

Therefore add a pillar (add_repo) that allows to disable adding the repo.

add_repo defaults to True for backward compability.
@aboe76 aboe76 requested review from blbradley and kpostrup June 7, 2017 08:49
Copy link

@kartnico kartnico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have a similar PR, but we use the map.jinja for the default value :
#40

@aboe76
Copy link
Member

aboe76 commented Nov 20, 2017

merged #40 instead of this one.

@aboe76 aboe76 closed this Nov 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants