Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(semantic-release): implement an automated changelog #24

Merged
merged 2 commits into from
May 18, 2019

Conversation

daks
Copy link
Member

@daks daks commented May 18, 2019

Implement semantic-release on fail2ban-formula.
I also implemented a very basic test which needs to be expanded to be useful.

I also discovered this formula has ng states so implementing versioning is a first step to be able to get rid of those.

@daks daks requested a review from myii May 18, 2019 15:15
@myii
Copy link
Member

myii commented May 18, 2019

Great work, I'll look at this shortly. One initial comment: do you mind limiting Travis to 5 instances, as we've discussed in this issue? Kitchen config is fine since those can still be run locally.

@myii
Copy link
Member

myii commented May 18, 2019

To be clear, I'm intending to go back to all semantic-release formulas and propose the same thing there, unless there is some justification.

Copy link
Member

@myii myii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an approval, really. Just some minor suggestions to either implement or ignore.

docs/TOFS_pattern.rst Outdated Show resolved Hide resolved
test/integration/default/inspec.yml Show resolved Hide resolved
@myii
Copy link
Member

myii commented May 18, 2019

@daks Thanks for this PR. The final point is it this is more of a feat than a docs. I'm not sure how we ended up with that commit type!

@daks
Copy link
Member Author

daks commented May 18, 2019

@myii not sure, but nearly all are of type 'docs', will change the commit message

@myii myii merged commit 70d53e3 into saltstack-formulas:master May 18, 2019
@myii
Copy link
Member

myii commented May 18, 2019

Thanks for another brilliant contribution @daks!

@daks
Copy link
Member Author

daks commented May 18, 2019

thanks for the merge

@saltstack-formulas-travis

🎉 This PR is included in version 0.15.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants