Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Add support for the AllowZoneDrifting option #44

Closed
MarinBernard opened this issue Oct 23, 2020 · 2 comments · Fixed by #45
Closed

[FEATURE] Add support for the AllowZoneDrifting option #44

MarinBernard opened this issue Oct 23, 2020 · 2 comments · Fixed by #45
Labels
enhancement released

Comments

@MarinBernard
Copy link

Is your feature request related to a problem?

For compatibility reasons, RHEL/CentOS 7/8 firewalld packages come with zone drifting enabled by default, while best practices are to keep it disabled.

Describe the solution you'd like

Disabling zone drifting requires adding AllowZoneDrifting = no to /etc/firewalld/firewalld.conf. Since this file is managed by the firewalld formula, it would be interesting to add support for this option to the formula.

Describe alternatives you've considered

None.

Additional context

None.
myii added a commit to myii/firewalld-formula that referenced this issue Oct 24, 2020
@myii
feat(firewalld.conf): support configuration of AllowZoneDrifting
4238626 
Close saltstack-formulas#44.
myii added a commit to myii/firewalld-formula that referenced this issue Oct 24, 2020
@myii
feat(firewalld.conf): support configuration of AllowZoneDrifting
0ff53ff 
Close saltstack-formulas#44.

Configuration description taken from:

* https://firewalld.org/documentation/man-pages/firewalld.conf.html
@myii myii mentioned this issue Oct 24, 2020
Merged
19 tasks
@myii
Copy link
Member

myii commented Oct 24, 2020

@MarinBernard Thanks for the detailed feature request. The links to sources is always appreciated.

Since the request is relatively simple, I've proposed #45 to resolve this issue. It would be helpful if you could confirm that it works for you -- please add any feedback to that PR.

The proper resolution would involve implementing TOFS for this formula. That would avoid needing to provide all of the possible configuration options in the template.

@myii myii closed this as completed in #45 Oct 24, 2020
saltstack-formulas-travis pushed a commit that referenced this issue Oct 24, 2020
@semantic-release-bot
chore(release): 1.1.0 [skip ci]
fd55653 
# [1.1.0](v1.0.0...v1.1.0) (2020-10-24)

### Continuous Integration

* **gemfile.lock:** add to repo with updated `Gemfile` [skip ci] ([7a964e4](7a964e4))
* **kitchen:** use `saltimages` Docker Hub where available [skip ci] ([a33cd64](a33cd64))
* **kitchen+travis:** remove `master-py2-arch-base-latest` [skip ci] ([24e115c](24e115c))
* **pre-commit:** add to formula [skip ci] ([9254027](9254027))
* **pre-commit:** enable/disable `rstcheck` as relevant [skip ci] ([c7e4dee](c7e4dee))
* **pre-commit:** finalise `rstcheck` configuration [skip ci] ([118eacf](118eacf))
* **travis:** add notifications => zulip [skip ci] ([b6c60b2](b6c60b2))
* **workflows/commitlint:** add to repo [skip ci] ([93853b6](93853b6))

### Features

* **firewalld.conf:** support configuration of `AllowZoneDrifting` ([0ff53ff](0ff53ff)), closes [#44](#44)
@saltstack-formulas-travis
Copy link

🎉 This issue has been resolved in version 1.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(firewalld.conf): support configuration of AllowZoneDrifting myii/firewalld-formula
3 participants
@myii @MarinBernard @saltstack-formulas-travis