Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include jobs.sls in init.sls? #57

Closed
mdschmitt opened this issue Jul 6, 2021 · 2 comments · Fixed by #58
Closed

Include jobs.sls in init.sls? #57

mdschmitt opened this issue Jul 6, 2021 · 2 comments · Fixed by #58

Comments

@mdschmitt
Copy link
Contributor

Just wondering why jobs.sls isn't part of init.sls ..?

Is there a specific reason it's not in there? I would think that the following line would make it so that it could be included without issue if there's no jobs definition in the pillar...

{% set jobs = salt['pillar.get']('logrotate:jobs', {}) %}
javierbertoli added a commit to netmanagers/logrotate-formula that referenced this issue Jul 6, 2021
javierbertoli added a commit to netmanagers/logrotate-formula that referenced this issue Jul 6, 2021
@javierbertoli
Copy link
Member

@mdschmitt I think there is no reason for not adding it. I submitted a PR to fix it.

@myii myii closed this as completed in #58 Jul 7, 2021
saltstack-formulas-travis pushed a commit that referenced this issue Jul 7, 2021
# [0.12.0](v0.11.5...v0.12.0) (2021-07-07)

### Continuous Integration

* **3003.1:** update inc. AlmaLinux, Rocky & `rst-lint` [skip ci] ([bb6bfac](bb6bfac))
* **commitlint:** ensure `upstream/master` uses main repo URL [skip ci] ([ac5a57c](ac5a57c))
* **gemfile+lock:** use `ssf` customised `kitchen-docker` repo [skip ci] ([7368305](7368305))
* **kitchen+gitlab:** remove Ubuntu 16.04 & Fedora 32 (EOL) [skip ci] ([1f55b57](1f55b57))
* add `arch-master` to matrix and update `.travis.yml` [skip ci] ([84b2f6a](84b2f6a))
* **gitlab-ci:** add `rubocop` linter (with `allow_failure`) [skip ci] ([1fc52cd](1fc52cd))
* **gitlab-ci:** use GitLab CI as Travis CI replacement ([94c2cf7](94c2cf7))
* **kitchen+ci:** use latest pre-salted images (after CVE) [skip ci] ([406dbbb](406dbbb))
* **kitchen+gitlab:** adjust matrix to add `3003` [skip ci] ([b198955](b198955))
* **kitchen+gitlab-ci:** use latest pre-salted images [skip ci] ([ea66a0d](ea66a0d))
* **pre-commit:** add to formula [skip ci] ([e506d69](e506d69))
* **pre-commit:** enable/disable `rstcheck` as relevant [skip ci] ([267bb94](267bb94))
* **pre-commit:** finalise `rstcheck` configuration [skip ci] ([bd1dc81](bd1dc81))
* **pre-commit:** update hook for `rubocop` [skip ci] ([2c964b0](2c964b0))

### Features

* **jobs:** add `jobs: {}` to defaults and state to init ([c3b64d3](c3b64d3)), closes [#57](#57)

### Tests

* **alma+rocky:** add platforms (based on CentOS 8) [skip ci] ([dc63042](dc63042))
* standardise use of `share` suite & `_mapdata` state [skip ci] ([650cfad](650cfad))
* **base:** update from `template-formula` and Arch Linux exclusion ([09d4f5a](09d4f5a))
* **rubocop:** fix violation [skip ci] ([3f5edef](3f5edef))
@saltstack-formulas-travis

🎉 This issue has been resolved in version 0.12.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants