Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openssh.config_ini / HostKey clobbering #146

Open
jtryon opened this issue Jan 24, 2019 · 1 comment
Open

openssh.config_ini / HostKey clobbering #146

jtryon opened this issue Jan 24, 2019 · 1 comment

Comments

@jtryon
Copy link

jtryon commented Jan 24, 2019

While testing the ini style config formula I've found that it clobbers the 4 default HostKey in the Ubuntu sshd_config down to the last one (without a HostKey specified in the pillar).

sshd_config Before

HostKey /etc/ssh/ssh_host_rsa_key
HostKey /etc/ssh/ssh_host_dsa_key
HostKey /etc/ssh/ssh_host_ecdsa_key
HostKey /etc/ssh/ssh_host_ed25519_key

sshd_config After

HostKey /etc/ssh/ssh_host_ed25519_key

Following the pillar.example style of HostKey config Salt fails to compile the SLS on the minion. I think that's just because the current pillar.example isn't made with the config_ini formula in mind (it has a list/block of hostkeys which causes the compile issue).

All the other config variables which only appear once aren't affected and update just fine.

@alxwr
Copy link
Member

alxwr commented Feb 12, 2019

@jtryon Thanks for your bug report.
The config_ini.sls variant is AFAIK developed independently of the "normal" config.sls. Furthermore I'm not sure whether config_ini.sls receives as much attention as config.sls.
Could you please submit a PR which fixes the issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants