Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(server/init): use |json to resolve 2019.2 breaking change #254

Merged
merged 1 commit into from
Mar 13, 2019
Merged

fix(server/init): use |json to resolve 2019.2 breaking change #254

merged 1 commit into from
Mar 13, 2019

Conversation

myii
Copy link
Member

@myii myii commented Mar 8, 2019

Fix confirmation: #253 (comment).

@myii myii requested a review from vutny March 8, 2019 09:24
@myii myii mentioned this pull request Mar 8, 2019
Closed
@myii
Copy link
Member Author

myii commented Mar 13, 2019 via email

@aboe76 aboe76 merged commit 57f80ee into master Mar 13, 2019
@aboe76
Copy link
Member

aboe76 commented Mar 13, 2019

merged it.

@myii myii deleted the myii-patch-1 branch March 13, 2019 17:11
@myii
Copy link
Member Author

myii commented Mar 13, 2019

@aboe76 Thanks.

@skurfer
Copy link
Contributor

skurfer commented Mar 14, 2019

I think this change also needs to be made in dev/init.sls and client/init.sls.

@vutny
Copy link
Contributor

vutny commented Mar 14, 2019

Good point @skurfer . Would you mind to submit a PR?

@skurfer skurfer mentioned this pull request Mar 14, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aboe76 aboe76 aboe76 approved these changes

@vutny vutny vutny approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@myii @aboe76 @skurfer @vutny