Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: enable Vagrant-based testing using GitHub Actions #502

Merged

Conversation

myii
Copy link
Member

@myii myii commented Mar 30, 2021

PR progress checklist (to be filled in by reviewers)

  • Changes to documentation are appropriate (or tick if not required)
  • Changes to tests are appropriate (or tick if not required)
  • Reviews completed

What type of PR is this?

Primary type

  • [build] Changes related to the build system
  • [chore] Changes to the build process or auxiliary tools and libraries such as documentation generation
  • [ci] Changes to the continuous integration configuration
  • [feat] A new feature
  • [fix] A bug fix
  • [perf] A code change that improves performance
  • [refactor] A code change that neither fixes a bug nor adds a feature
  • [revert] A change used to revert a previous commit
  • [style] Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)

Secondary type

  • [docs] Documentation changes
  • [test] Adding missing or correcting existing tests

Does this PR introduce a BREAKING CHANGE?

No.

Related issues and/or pull requests

Describe the changes you're proposing

Explaining commit-by-commit:

ci: enable Vagrant-based testing using GitHub Actions

  • As explained at the URL mentioned above.

docs(readme): add Testing with Vagrant section

  • Explain how to run these Vagrant-based tests locally.

fix(osfamilymap): use whoami for Windows rootuser

test: add Windows map verification files

  • Add map.jinja verification files for all Windows platforms.

test(_mapdata): add Arch Linux verification file

  • Add map.jinja verification files for Arch Linux.

refactor(retry_options): provide options from defaults/pillar

  • Centralise retry_options as done in many other formulas.

fix(freebsd): update to provide support for most recent versions

  • Add the new data in osmap.yaml.
  • Make adjustments to ensure all instances pass in the CI.
  • Add map.jinja verification files for FreeBSD.

fix(openbsd): update to provide support for most recent versions

  • Add the new data in osmap.yaml.
  • Add map.jinja verification files for OpenBSD.

test: update for new platforms (inc. using system library)

  • Update all tests to include the new platforms.
  • Use the system library throughout.

Pillar / config required to test the proposed changes

As-is.

Debug log showing how the proposed changes work

As shown in the CI.

Documentation checklist

  • Updated the README (e.g. Available states).
  • Updated pillar.example.

Testing checklist

  • Included in Kitchen (i.e. under state_top).
  • Covered by new/existing tests (e.g. InSpec, Serverspec, etc.).
  • Updated the relevant test pillar.

Additional context

@myii myii requested review from a team as code owners March 30, 2021 11:56
Copy link
Contributor

@baby-gnu baby-gnu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe homogenize the use of system.platform over platform?

test/integration/v3000-py2/controls/service_spec.rb Outdated Show resolved Hide resolved
test/integration/v3000-py3/controls/service_spec.rb Outdated Show resolved Hide resolved
test/integration/v3002-py3/controls/service_spec.rb Outdated Show resolved Hide resolved
test/integration/v3001-py3/controls/service_spec.rb Outdated Show resolved Hide resolved
@myii myii force-pushed the ci/add-vagrant-testing-via-github-actions branch from de6727a to e6bcdc1 Compare March 30, 2021 12:21
@myii myii merged commit 5523523 into saltstack-formulas:master Mar 30, 2021
@myii myii deleted the ci/add-vagrant-testing-via-github-actions branch March 30, 2021 13:03
@myii
Copy link
Member Author

myii commented Mar 30, 2021

Self-merge since mostly CI, tests and docs. Other minor changes don't affect other platforms other than the new ones introduced here.

Thanks for the review, @baby-gnu!

@saltstack-formulas-travis

🎉 This PR is included in version 1.8.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants