Add server side checks #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EvaSDK
force-pushed
the
add-server-side-checks
branch
2 times, most recently
from
325bf55
to
18f935a
Compare
According to Sensu documentation [1], sensu-server is responsible for distributing checks, while clients may have their own local checks. Make sure the formula can deal with it. Move chunk in client.sls to allow easier diff with server.sls. [1] https://sensuapp.org/docs/0.28/overview/architecture.html#check-execution-scheduler
Move service handling at the same position for easier diff reading.
client and server state can be present on the same node. Use names found in the documentation of Sensu for better understanding.
EvaSDK
force-pushed
the
add-server-side-checks
branch
from
9de51dc
to
f8fd85d
Compare
|
Just to clarify @EvaSDK , this PR:
|
|
Basically yes. You could see it the other way around, it all depends on which state you included for your nodes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to Sensu documentation, sensu-server is responsible for distributing checks, while clients may have their own local checks. Make sure the formula can deal with it.
I am in the process of splitting a mono server installation and there is no guarantee that a client will run on the same machine as the server so I need this to work as documented in upstream documentation. I also found some other oddities of the same kind but this is my main problem right now.