When creating directory that is included from agent config, strip filename or glob at the end #145
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR progress checklist (to be filled in by reviewers)
What type of PR is this?
Primary type
[fix]
A bug fixDoes this PR introduce a
BREAKING CHANGE
?Potentially.
Currently all the examples seem to end with "/" if it's an directory, so should work. If user creates an include "/path/to/an/directory", it will only create "/path/to/an/", as it doesn't have a way to determine it better, than the slash at the end.
Related issues and/or pull requests
#111
Describe the changes you're proposing
Strip the filename or glob at the end of the path, if it's not a directory
Pillar / config required to test the proposed changes
try with both a directory (ending in "/") and a file-like path in agent includes, i did with
zabbix:
lookup:
agent:
includes:
- /etc/zabbix/zabbix_agent2.d/*.conf
- /tmp/test/
Debug log showing how the proposed changes work
Documentation checklist
no need to update examples/docs
Testing checklist
I did not write tests to this, is it necessary for such bugfix?