Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PyPI version is wrong #42

Closed
kottenator opened this issue Jul 1, 2015 · 9 comments
Closed

PyPI version is wrong #42

kottenator opened this issue Jul 1, 2015 · 9 comments
Labels

Comments

@kottenator
Copy link

On PyPI, there is salt-pepper==0.3.5 (only)
When I do pip install salt-pepper, it fetches salt-pepper-0.3.5.tar.gz and installs it.
But then I do pip freeze | gerp pepper and it shows salt-pepper==0.0.0
Also, could you keep all previous versions on PyPI and not delete them?

@whiteinge
Copy link
Contributor

I can reproduce this. Do you know where pip fetches that version information from? It should be available in the metadata but it looks like I missed something.

I don't delete old releases off PyPI. Try editing the URL: Example:

https://pypi.python.org/pypi?name=salt-pepper&version=0.2.0&:action=display

@whiteinge whiteinge added the bug label Jul 1, 2015
@kottenator
Copy link
Author

Yes, now I see that all versions are presented, excuse me

@kottenator
Copy link
Author

However, installed version is still 0.0.0 :)
Sorry, I can't quickly find the reason of the bug

@whiteinge
Copy link
Contributor

whiteinge commented Jul 6, 2015 via email

@EugeniuZ
Copy link

EugeniuZ commented Nov 6, 2015

I believe this is the source of the bug: https://github.com/saltstack/pepper/blob/master/setup.py#L47
git_dir is empty after this call and as a result version and sha are None.

To be more precise: it works when you install it from the local git folder but it won't work if you install it from pypi.

@whiteinge
Copy link
Contributor

Oh, good catch! You're right. If there's no Git directory we should look for the JSON file instead. facepalm

If you care to send a pull req with the fix, I will push a new version to PyPI.

@EugeniuZ
Copy link

EugeniuZ commented Nov 6, 2015

#61

@whiteinge
Copy link
Contributor

Thanks for the fix! Release 0.4.0 is now cut and uploaded to PyPI.

@EugeniuZ
Copy link

EugeniuZ commented Nov 6, 2015

You're welcome. Thanks for uploading it so fast.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants