Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change local to map expr_form to tgt_type #214

Closed
wants to merge 1 commit into from

Conversation

jheiselman
Copy link
Contributor

This resolves #213

Changed expr_form to tgt_type in payload passed in via local()
@nicholasmhughes
Copy link
Collaborator

Howdy! 👋

Apologies for the long delay on this integrating this code. We certainly appreciate your effort!

Pepper is getting some renewed focus and love, and we're checking in to see if you'd like to update this against the latest version of the base branch and ensure that all merge conditions are met.

If the items addressed by this contribution have already been fixed/added, are no longer an issue, or you no longer have a desire to work on this... please let us know and/or close out this PR.

If we don't hear from you within 7 days, we'll assume the code has been abandoned and close it out. If you'd like to revisit this in the future, you can always open a new PR.

Thank you, and we hope to see you active in the Salt ecosystem in the future!

@jheiselman
Copy link
Contributor Author

There is no base branch in your repository. My change is not also not behind the current commit on your develop branch.

@barneysowood
Copy link
Collaborator

@jheiselman - would you also be able to re-base this on to develop and add some tests?

Could you also update the other local functions (local_async and local_batch)?

Thanks very much!

@the-glu
Copy link

the-glu commented May 3, 2023

I just noticed this one, this is also fixed by #186 (with extra fixes) ^^'

@jheiselman
Copy link
Contributor Author

I'll close this one. #186 should be the focus since it's more encompassing.

@jheiselman jheiselman closed this May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No way to pass tgt_type to API
4 participants