Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test PyTest 7.0.x and 7.1.x & Fix tests requirements #116

Merged
merged 14 commits into from
May 9, 2022

Conversation

s0undt3ch
Copy link
Member

No description provided.

Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
@codecov
Copy link

codecov bot commented Apr 16, 2022

Codecov Report

Merging #116 (5000932) into master (20bac18) will increase coverage by 0.72%.
The diff coverage is 98.64%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #116      +/-   ##
==========================================
+ Coverage   83.68%   84.39%   +0.72%     
==========================================
  Files          89       92       +3     
  Lines        5103     5220     +117     
  Branches      578      582       +4     
==========================================
+ Hits         4270     4405     +135     
+ Misses        640      631       -9     
+ Partials      193      184       -9     
Flag Coverage Δ
Linux 83.68% <96.58%> (+0.36%) ⬆️
Py35 66.54% <43.42%> (-0.42%) ⬇️
Py36 82.88% <96.13%> (+0.38%) ⬆️
Py37 83.18% <96.90%> (+0.58%) ⬆️
Py38 83.62% <96.58%> (+0.73%) ⬆️
Py39 83.64% <96.58%> (+0.73%) ⬆️
PyTest60 ?
PyTest61 68.01% <50.00%> (-15.31%) ⬇️
PyTest62 83.84% <97.27%> (+0.49%) ⬆️
PyTest70 83.87% <97.27%> (+1.38%) ⬆️
PyTest71 83.87% <97.27%> (+0.96%) ⬆️
Windows 78.60% <94.58%> (?)
macOS 79.50% <96.13%> (+0.50%) ⬆️
src 76.52% <78.58%> (+0.34%) ⬆️
tests 95.24% <99.25%> (+0.31%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/saltfactories/cli/key.py 100.00% <ø> (ø)
src/saltfactories/bases.py 76.42% <66.67%> (+0.67%) ⬆️
src/saltfactories/cli/cp.py 100.00% <100.00%> (ø)
src/saltfactories/cli/run.py 100.00% <100.00%> (+18.19%) ⬆️
src/saltfactories/cli/salt.py 100.00% <100.00%> (ø)
src/saltfactories/manager.py 89.29% <100.00%> (ø)
tests/integration/conftest.py 100.00% <100.00%> (ø)
tests/integration/factories/cli/conftest.py 100.00% <100.00%> (ø)
tests/integration/factories/cli/test_salt.py 100.00% <100.00%> (ø)
...ntegration/factories/daemons/master/test_master.py 100.00% <100.00%> (ø)
... and 16 more

@s0undt3ch s0undt3ch force-pushed the master branch 4 times, most recently from 01f4bcf to 0880e48 Compare April 17, 2022 10:51
Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
…NT`` env var.

Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
Now that the new logging changes are merged into Salt's master branch, adjust detection of those changes on ``SaltKey``.

Fixes saltstack#118

Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
``--timeout`` is now correctly passed for CLI factories when either ``timeout`` is defined on the configuration or when ``timeout`` is passed to the CLI factory constructor.

Fixes saltstack#117

Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant