Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Daemon.started() is now a context manager #23

Merged
merged 1 commit into from May 26, 2022

Conversation

s0undt3ch
Copy link
Member

Fixes #22

Signed-off-by: Pedro Algarvio palgarvio@vmware.com

@s0undt3ch s0undt3ch requested a review from a team as a code owner May 26, 2022 18:58
@s0undt3ch s0undt3ch requested a review from Ch3LL May 26, 2022 18:58
@codecov
Copy link

codecov bot commented May 26, 2022

Codecov Report

Merging #23 (534adbd) into main (5d56fb3) will increase coverage by 3.98%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #23      +/-   ##
==========================================
+ Coverage   87.50%   91.47%   +3.98%     
==========================================
  Files          31       22       -9     
  Lines        2359     1547     -812     
  Branches      345      213     -132     
==========================================
- Hits         2064     1415     -649     
+ Misses        222      102     -120     
+ Partials       73       30      -43     
Flag Coverage Δ
src 86.10% <100.00%> (+3.21%) ⬆️
tests 96.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/pytestshellutils/shell.py 89.36% <100.00%> (+0.08%) ⬆️
src/pytestshellutils/__init__.py 43.34% <0.00%> (-50.00%) ⬇️
src/pytestshellutils/utils/processes.py 85.72% <0.00%> (-1.24%) ⬇️
src/pytestshellutils/downgraded/shell.py
src/pytestshellutils/downgraded/exceptions.py
src/pytestshellutils/downgraded/utils/socket.py
src/pytestshellutils/downgraded/utils/time.py
src/pytestshellutils/downgraded/utils/processes.py
src/pytestshellutils/downgraded/utils/ports.py
src/pytestshellutils/downgraded/utils/__init__.py
... and 2 more

Fixes saltstack#22

Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Daemon.started should be a context manager
2 participants