Use flake8 for fast lintint.
#58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PyLint should not be discarded since it does some deeper inspection, but flake8 is fast enough that we can even have it in a pre-commit hook. Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
s0undt3ch
commented
Dec 2, 2022
Comment on lines
+229
to
+231
| libcrypt.so.2 => {libcrypt} (0x0123456789) | ||
| libm.so.6 => /usr/lib/libm.so.6 (0x0123456789) | ||
| libc.so.6 => /usr/lib/libc.so.6 (0x0123456789) |
There was a problem hiding this comment.
Are the tabs really important here?
s0undt3ch
commented
Dec 2, 2022
Comment on lines
+257
to
+260
| libcrypt.so.2 => {libcrypt} (0x0123456789) | ||
| fake.so.2 => {fake} (0x0123456789) | ||
| libm.so.6 => /usr/lib/libm.so.6 (0x0123456789) | ||
| libc.so.6 => /usr/lib/libc.so.6 (0x0123456789) |
There was a problem hiding this comment.
Are the tabs really important here?
dwoz
reviewed
Dec 2, 2022
| owner = root | ||
| group = root | ||
|
|
||
| [flake8] |
There was a problem hiding this comment.
Can this config reside in pyproject.toml?
There was a problem hiding this comment.
dwoz
approved these changes
Dec 2, 2022
dwoz
reviewed
Dec 2, 2022
| @@ -21,3 +21,62 @@ include_package_data = True | |||
| [options.entry_points] | |||
| console_scripts = | |||
| relenv = relenv.__main__:main | |||
|
|
|||
| [sdist] | |||
| owner = root | |||
There was a problem hiding this comment.
Is this definitely needed? pypa/setuptools#2800
There was a problem hiding this comment.
yes, I believe root is not the default user. It'll use which ever user is creating the tarball.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PyLint should not be discarded since it does some deeper inspection, but flake8 is fast enough that we can even have it in a pre-commit hook.