Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hash verification information to installation instructions #1098

Merged
merged 1 commit into from
Jun 19, 2017

Conversation

rallytime
Copy link
Contributor

Fixes #1043

cc: @cachedout

Copy link
Contributor

@vutny vutny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is OK in general.

But it would be really nice to have a hash sum in a separate file and be able to verify it automatically (and generate it the same way).
For example:

curl -L https://bootstrap.saltstack.com/bootstrap-salt.sh.sha512 | sha512sum -c -

@rallytime
Copy link
Contributor Author

@vutny Yes, I agree. I was thinking about doing it that way as well, but then I wasn't sure where to put it right now. We could add the sum files to repo.saltstack.com, one for each new release of the bootstrap script. This would be similar to how we do this for the windows executables: https://repo.saltstack.com/#windows

I think for now this is a good start, though, until we can get that added to repo.saltstack.com. I want to loop @Ch3LL in here for getting something like this added to the bootstrap release process. @Ch3LL what do you think?

@Ch3LL
Copy link
Contributor

Ch3LL commented Jun 13, 2017

We could possibly just add it to bootstrap.saltstack.com but I would like to get @UtahDave 's input here since he is more familiar with how that is setup to see if this is a possibility. That way the sha is in the same subdomain.

@rallytime
Copy link
Contributor Author

@Ch3LL Oh yes, you're right. The same subdomain is best. :) We're already doing this with the Windows sum files, so I think we should do this with the bootstrap releases as well.

@rallytime
Copy link
Contributor Author

I think this is good for now from a bootstrap script perspective. We'll have to follow up with the file repo conversation at a later time.

@rallytime rallytime merged commit f581f39 into saltstack:develop Jun 19, 2017
@rallytime rallytime deleted the fix-1043 branch June 19, 2017 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants