Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ubuntu 16.04 LTS installation #1102

Merged
merged 1 commit into from
Jun 13, 2017

Conversation

BlaineAtAffirm
Copy link
Contributor

What does this PR do?

This PR fixes an error when bootstrapping salt on the docker image ubuntu:16.04 . It would use ppa's with codename jessie (debian) rather than the correct name xenial (ubuntu)

What issues does this PR fix or reference?

error was

18:24:59 Hit:1 http://archive.ubuntu.com/ubuntu xenial InRelease
18:24:59 Hit:2 http://security.ubuntu.com/ubuntu xenial-security InRelease

18:24:59 Hit:3 http://archive.ubuntu.com/ubuntu xenial-updates InRelease
18:24:59 Hit:4 http://archive.ubuntu.com/ubuntu xenial-backports InRelease
18:24:59 Ign:5 https://repo.saltstack.com/apt/ubuntu/16.04/amd64/2015.8 jessie InRelease
18:24:59 Ign:6 https://repo.saltstack.com/apt/ubuntu/16.04/amd64/2015.8 jessie Release
18:24:59 Ign:7 https://repo.saltstack.com/apt/ubuntu/16.04/amd64/2015.8 jessie/main amd64 Packages
18:24:59 Ign:8 https://repo.saltstack.com/apt/ubuntu/16.04/amd64/2015.8 jessie/main all Packages
18:24:59 Ign:7 https://repo.saltstack.com/apt/ubuntu/16.04/amd64/2015.8 jessie/main amd64 Packages
18:24:59 Ign:8 https://repo.saltstack.com/apt/ubuntu/16.04/amd64/2015.8 jessie/main all Packages
18:24:59 Ign:7 https://repo.saltstack.com/apt/ubuntu/16.04/amd64/2015.8 jessie/main amd64 Packages
18:25:00 Ign:8 https://repo.saltstack.com/apt/ubuntu/16.04/amd64/2015.8 jessie/main all Packages
18:25:00 Ign:7 https://repo.saltstack.com/apt/ubuntu/16.04/amd64/2015.8 jessie/main amd64 Packages
18:25:00 Ign:8 https://repo.saltstack.com/apt/ubuntu/16.04/amd64/2015.8 jessie/main all Packages
18:25:00 Ign:7 https://repo.saltstack.com/apt/ubuntu/16.04/amd64/2015.8 jessie/main amd64 Packages
18:25:00 Ign:8 https://repo.saltstack.com/apt/ubuntu/16.04/amd64/2015.8 jessie/main all Packages
18:25:00 Err:7 https://repo.saltstack.com/apt/ubuntu/16.04/amd64/2015.8 jessie/main amd64 Packages
18:25:00   404  Not Found
18:25:00 Ign:8 https://repo.saltstack.com/apt/ubuntu/16.04/amd64/2015.8 jessie/main all Packages

18:25:01 Reading package lists...
18:25:01 W: The repository 'https://repo.saltstack.com/apt/ubuntu/16.04/amd64/2015.8 jessie Release' does not have a Release file.
18:25:01 E: Failed to fetch https://repo.saltstack.com/apt/ubuntu/16.04/amd64/2015.8/dists/jessie/main/binary-amd64/Packages  404  Not Found
18:25:01 E: Some index files failed to download. They have been ignored, or old ones used instead.
18:25:01  * ERROR: Failed to run install_ubuntu_stable_deps()!!!

Previous Behavior

apt-get update would sometimes fail due to the bad codename

New Behavior

apt-get update should succeed consistently

error was
```
18:24:59 Hit:1 http://archive.ubuntu.com/ubuntu xenial InRelease
18:24:59 Hit:2 http://security.ubuntu.com/ubuntu xenial-security InRelease

18:24:59 Hit:3 http://archive.ubuntu.com/ubuntu xenial-updates InRelease
18:24:59 Hit:4 http://archive.ubuntu.com/ubuntu xenial-backports InRelease
18:24:59 Ign:5 https://repo.saltstack.com/apt/ubuntu/16.04/amd64/2015.8 jessie InRelease
18:24:59 Ign:6 https://repo.saltstack.com/apt/ubuntu/16.04/amd64/2015.8 jessie Release
18:24:59 Ign:7 https://repo.saltstack.com/apt/ubuntu/16.04/amd64/2015.8 jessie/main amd64 Packages
18:24:59 Ign:8 https://repo.saltstack.com/apt/ubuntu/16.04/amd64/2015.8 jessie/main all Packages
18:24:59 Ign:7 https://repo.saltstack.com/apt/ubuntu/16.04/amd64/2015.8 jessie/main amd64 Packages
18:24:59 Ign:8 https://repo.saltstack.com/apt/ubuntu/16.04/amd64/2015.8 jessie/main all Packages
18:24:59 Ign:7 https://repo.saltstack.com/apt/ubuntu/16.04/amd64/2015.8 jessie/main amd64 Packages
18:25:00 Ign:8 https://repo.saltstack.com/apt/ubuntu/16.04/amd64/2015.8 jessie/main all Packages
18:25:00 Ign:7 https://repo.saltstack.com/apt/ubuntu/16.04/amd64/2015.8 jessie/main amd64 Packages
18:25:00 Ign:8 https://repo.saltstack.com/apt/ubuntu/16.04/amd64/2015.8 jessie/main all Packages
18:25:00 Ign:7 https://repo.saltstack.com/apt/ubuntu/16.04/amd64/2015.8 jessie/main amd64 Packages
18:25:00 Ign:8 https://repo.saltstack.com/apt/ubuntu/16.04/amd64/2015.8 jessie/main all Packages
18:25:00 Err:7 https://repo.saltstack.com/apt/ubuntu/16.04/amd64/2015.8 jessie/main amd64 Packages
18:25:00   404  Not Found
18:25:00 Ign:8 https://repo.saltstack.com/apt/ubuntu/16.04/amd64/2015.8 jessie/main all Packages

18:25:01 Reading package lists...
18:25:01 W: The repository 'https://repo.saltstack.com/apt/ubuntu/16.04/amd64/2015.8 jessie Release' does not have a Release file.
18:25:01 E: Failed to fetch https://repo.saltstack.com/apt/ubuntu/16.04/amd64/2015.8/dists/jessie/main/binary-amd64/Packages  404  Not Found
18:25:01 E: Some index files failed to download. They have been ignored, or old ones used instead.
18:25:01  * ERROR: Failed to run install_ubuntu_stable_deps()!!!
```
Copy link
Contributor

@rallytime rallytime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, good catch. Thank you!

@rallytime rallytime merged commit 74eb529 into saltstack:develop Jun 13, 2017
@BlaineAtAffirm BlaineAtAffirm deleted the patch-1 branch June 13, 2017 20:37
@BlaineAtAffirm
Copy link
Contributor Author

thank you for the quick review @rallytime :) if only PR reviews in all repos were this quick hahaha

@rallytime
Copy link
Contributor

@BlaineAtAffirm Yeah! Happy to get your fix in. Thanks for submitting it. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants