Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 1105 #1110

Merged
merged 2 commits into from
Jun 30, 2017
Merged

Fix 1105 #1110

merged 2 commits into from
Jun 30, 2017

Conversation

vernondcole
Copy link
Contributor

What does this PR do?

What issues does this PR fix or reference?

#1105

Previous Behavior

salt-bootstrap.sh -F caused overwrite of the minion config, but not the keys.

sh salt-bootstrap.sh failed with

 $ sudo sh salt-bootstrap.sh -A salt.2txt.us -i sb1
 *  INFO: Running version: 2017.05.24
 *  INFO: Executed by: sh
 *  INFO: Command line: 'salt-bootstrap.sh -A salt.2txt.us -i sb1'
 *  WARN: Running the unstable version of bootstrap-salt.sh

 *  INFO: System Information:
 *  INFO:   CPU:          GenuineIntel
 *  INFO:   CPU Arch:     x86_64
 *  INFO:   OS Name:      Linux
 *  INFO:   OS Version:   3.2.0-126-virtual
 *  INFO:   Distribution: Ubuntu 12.04

 * ERROR: End of life distributions are not supported.
 * ERROR: Please consider upgrading to the next stable. See:
 * ERROR:     https://wiki.ubuntu.com/Releases

New Behavior

  • Key files will be replaced, too.
  • Can actually test using Vagrant

Copy link
Contributor

@vutny vutny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job @vernondcole !

Since passing -C (config only) option implies -F (forced overwrite), this is backwards compatible and more useful.

@rallytime
Copy link
Contributor

@vernondcole Yes, this is the right way to do this. Thank you for fixing this!

@rallytime rallytime merged commit 8beefb2 into saltstack:develop Jun 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants