Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1137: import GPG key through an HTTP(S) proxy #1139

Merged
merged 3 commits into from
Sep 7, 2017
Merged

Fix #1137: import GPG key through an HTTP(S) proxy #1139

merged 3 commits into from
Sep 7, 2017

Conversation

vutny
Copy link
Contributor

@vutny vutny commented Aug 30, 2017

What does this PR do?

This PR makes GnuPG >= 2.1 to be aware of proxy settings and be able to download SaltStack's repo public key on Debian 9 and Ubuntus >= 16.10.

What issues does this PR fix or reference?

It should fix #1137... to some extend.

The problem with modern version of GnuPG and its component called dirmngr is that it does not send HTTP CONNECT method to the proxy server to open the tunnel on TLS port (e.g. 443).
There are two options to overcome this:

  • Configure proxy or firewall to be transparent for both http and https traffic, and listening on the same port. Probably it would require to redirect TLS connections to other proxy port.
  • Disable TLS in bootstrap by using -l command line option.

Copy link
Contributor

@rallytime rallytime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good.

@rallytime rallytime merged commit f24508b into saltstack:develop Sep 7, 2017
@vutny vutny deleted the fix-1137 branch September 8, 2017 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bootstrap of Debian family broken in 2017.08.17
2 participants