Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding bits to install Salt packages built using Tiamat. #1819

Merged
merged 19 commits into from
Jul 27, 2022

Conversation

garethgreenaway
Copy link
Contributor

What does this PR do?

Adding bits to install Salt packages built using Tiamat.

What issues does this PR fix or reference?

N/A

@garethgreenaway garethgreenaway changed the title [WIP] Adding bits to install Salt packages built using Tiamat. Adding bits to install Salt packages built using Tiamat. Jul 22, 2022
Copy link
Contributor

@Ch3LL Ch3LL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one small question. Also it looks like there are test failures

bootstrap-salt.sh Outdated Show resolved Hide resolved
@krionbsd krionbsd merged commit af68de6 into develop Jul 27, 2022
@myii
Copy link
Contributor

myii commented Jul 29, 2022

@garethgreenaway Tested this out in the Formulas' salt-image-builder CI (actually used #1845). We've already been building Docker images for tiamat for some time now, so converted things over for onedir. Hit some errors, particularly with RedHat 7 distros.

https://gitlab.com/myii/salt-image-builder/-/pipelines/600150567

  • Ignore Debian 9 and 12, since they're not available for onedir
  • Also ignore CentOS Stream 8, which has some temporary repo 404 errors

Amazon Linux 2

*  INFO: Running version: 2022.05.19
 *  INFO: Executed by: 
 *  INFO: Command line: 'sh -XUdfPD -x python3 onedir_rc latest'
 *  WARN: Running the unstable version of bootstrap-salt.sh
 *  INFO: System Information:
 *  INFO:   CPU:          GenuineIntel
 *  INFO:   CPU Arch:     x86_64
 *  INFO:   OS Name:      Linux
 *  INFO:   OS Version:   5.4.109+
 *  INFO:   Distribution: Amazon Linux AMI 2
 * DEBUG: Binaries will be searched using the following $PATH: /usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
 *  INFO: Installing minion
 *  INFO: Daemons will not be started
100  317k  100  317k    0     0   750k      0 --:--:-- --:--:-- --:--:--  749k
 * DEBUG: install_amazon_linux_ami_2_onedir_deps not found....
 *  INFO: Found function install_amazon_linux_ami_2_deps
 * DEBUG: DEPS_INSTALL_FUNC=install_amazon_linux_ami_2_deps
 * DEBUG: config_amazon_linux_ami_2_onedir_salt not found....
 * DEBUG: config_amazon_linux_ami_2_salt not found....
 * DEBUG: config_amazon_linux_ami_onedir_salt not found....
 * DEBUG: config_amazon_linux_ami_salt not found....
 *  INFO: Found function config_salt
 * DEBUG: CONFIG_SALT_FUNC=config_salt
 * DEBUG: preseed_amazon_linux_ami_2_onedir_master not found....
 * DEBUG: preseed_amazon_linux_ami_2_master not found....
 * DEBUG: preseed_amazon_linux_ami_onedir_master not found....
 * DEBUG: preseed_amazon_linux_ami_master not found....
 *  INFO: Found function preseed_master
 * DEBUG: PRESEED_MASTER_FUNC=preseed_master
 * DEBUG: INSTALL_FUNC_NAMES=install_amazon_linux_ami_2_onedir install_amazon_linux_ami_2_onedir install_amazon_linux_ami_onedir
 * DEBUG: install_amazon_linux_ami_2_onedir not found....
 * DEBUG: install_amazon_linux_ami_onedir not found....
 * DEBUG: INSTALL_FUNC=null
 * DEBUG: install_amazon_linux_ami_2_onedir_post not found....
 * DEBUG: install_amazon_linux_ami_2_post not found....
 * DEBUG: install_amazon_linux_ami_onedir_post not found....
 * DEBUG: install_amazon_linux_ami_post not found....
 * DEBUG: POST_INSTALL_FUNC=null
 * DEBUG: install_amazon_linux_ami_2_onedir_restart_daemons not found....
 *  INFO: Found function install_amazon_linux_ami_2_restart_daemons
 * DEBUG: STARTDAEMONS_INSTALL_FUNC=install_amazon_linux_ami_2_restart_daemons
 * DEBUG: daemons_running_amazon_linux_ami_2_onedir not found....
 * DEBUG: daemons_running_amazon_linux_ami_2 not found....
 * DEBUG: daemons_running_amazon_linux_ami_onedir not found....
 * DEBUG: daemons_running_amazon_linux_ami not found....
 *  INFO: Found function daemons_running_onedir
 * DEBUG: DAEMONS_RUNNING_FUNC=daemons_running_onedir
 * DEBUG: CHECK_SERVICES_FUNC=null
 * ERROR: No installation function found. Exiting...
  • The install_amazon_linux_ami_onedir* functions haven't been added to the bootstrap script.

CentOS 7 & Oracle Linux 7

 * ERROR: https://repo.saltproject.io/salt_rc/salt/py3/redhat/7/x86_64/base/RPM-GPG-KEY-CentOS-7 failed to download to /tmp/salt-gpg-FwdrQQEM.pub
 * ERROR: Failed to run install_centos_onedir_deps()!!!
 * ERROR: https://repo.saltproject.io/salt_rc/salt/py3/redhat/7/x86_64/base/RPM-GPG-KEY-CentOS-7 failed to download to /tmp/salt-gpg-MC6OK3N3.pub
 * ERROR: Failed to run install_oracle_linux_onedir_deps()!!!

@garethgreenaway
Copy link
Contributor Author

@myii thanks! Will check these issues out.

@garethgreenaway garethgreenaway deleted the adding_install_from_tiamat branch August 1, 2022 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants