Minion keys and /etc/salt/minion should be overwritten on -C #541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fig are overwritten
|
There's a flag to force overwrites on existing files. Web shouldn't just overwrite without users being aware... |
|
@cro any thoughts about my comment above? |
|
Sorry, I lost track of this issue. All -C does is overwrite files, though, correct? Isn't it redundant to have someone pass --force and -C? |
|
I think I'll default overwrite to True when -C is passed and wait some seconds for user interruption with a big fat warning. |
Merged
s0undt3ch
added a commit
that referenced
this pull request
Jan 13, 2016
jfindlay
added a commit
to jfindlay/salt-bootstrap
that referenced
this pull request
Jan 13, 2016
Updates saltstack#544 with the ideas in saltstack#541.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If user passes -C to configure only, overwrite any existing minion keys or /etc/salt/minion.