Fix multiple lint errors (shellcheck) and make some refactoring #768
Conversation
| # NAME: linkfile | ||
| # DESCRIPTION: Simple function to create symlinks. Overrides if asked. Accepts globs. | ||
| #---------------------------------------------------------------------------------------------------------------------- | ||
| linkfile() { |
There was a problem hiding this comment.
Please prefix this with __. The only intent is to "tell" someone reading that it's an internal function, there's no other gain from that.
|
The Thanks for cleaning up the script. You can see the lint information right? https://jenkins-testing.saltstack.com/job/bootstrap/job/pr/job/768/job/lint/1/violations/file/bootstrap-salt.sh/ |
|
Dam, this Jenkins setup is not right(it's setting commit status here form another PR).... |
|
Thanks @s0undt3ch |
|
@s0undt3ch I've fixed all lint warnings from previous build, but the last time it showed up something totally unrelated to my version (obviously wrong PR 666): https://jenkins-testing.saltstack.com/job/bootstrap/job/pr/job/666/job/lint/34/violations/file/bootstrap-salt.sh/ I guess this PR is OK for now. Could you please take a look? |
|
@s0undt3ch Do you have some time to review this PR? Thanks! |
vutny
changed the title
|
Ping @s0undt3ch |
Fix multiple lint errors (shellcheck) and make some refactoring
|
Sorry about the slowness. |
Plus style and logic corrections, mostly for FreeBSD and OpenBSD.