New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates, fixes, parametrize versions #42
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lkubb
force-pushed
the
fixes-improvements
branch
from
November 13, 2023 13:00
9d8d2ef
to
77d368e
Compare
3.5 and 3.6 have been EOL for a long time and are not compatible with the current pre-commit hooks
* asottile/blacken-docs has been moved to adamchainz/blacken-docs * click<8.1.0 is only required for old versions of black
lkubb
force-pushed
the
fixes-improvements
branch
from
November 13, 2023 13:03
77d368e
to
2c676c9
Compare
lkubb
force-pushed
the
fixes-improvements
branch
from
November 13, 2023 13:30
d704be1
to
12b4261
Compare
lkubb
force-pushed
the
fixes-improvements
branch
2 times, most recently
from
November 14, 2023 02:51
d53f1dd
to
0ce23a1
Compare
lkubb
force-pushed
the
fixes-improvements
branch
from
November 14, 2023 12:07
0ce23a1
to
7a71843
Compare
python_requires should have been bumped in 2.3.0
and rely on pylint's inbuilt parallelism
Merged
s0undt3ch
requested changes
Dec 22, 2023
s0undt3ch
approved these changes
Dec 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please excuse me packing all of this into a single PR:
pre-commit
less unhappy with the generated filesrequirements-files
and declares the rest of the extra requirements insetup.cfg
since they are not needed forpip-compile
pytest-salt-factories
is at least1.0.0rc19
, below that will not work anyways<3003
+loaders.py
since these versions are long EOLmost recentoldest currently supported version (3005
)saltstack/salt@master
itself (or the most recent ones supported by Python 3.7, depending on declared version support)apache
license ifother
was specifiedFixes: #34
Fixes: #35
Fixes: #43
The first commit now works without issues again.