Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates, fixes, parametrize versions #42

Merged
merged 19 commits into from Dec 26, 2023

Conversation

lkubb
Copy link
Contributor

@lkubb lkubb commented Nov 13, 2023

Please excuse me packing all of this into a single PR:

  • Makes pre-commit less unhappy with the generated files
  • Syntax cleanup/fixes execution module docstring
  • Adds the requirements files from the latest release to the repo (Is there a reason they are missing here?), corrects the entries in requirements-files and declares the rest of the extra requirements in setup.cfg since they are not needed for pip-compile
  • Ensures pytest-salt-factories is at least 1.0.0rc19, below that will not work anyways
  • Allows Python/Salt versions to be parametrized + adds 2 new options for this feature
  • Ensures Pylint knows about the minimum supported version
  • Removes the hint about <3003 + loaders.py since these versions are long EOL
  • Makes the tool default to the most recent oldest currently supported version (3005)
  • Python 3.5/3.6 have not been supported for the pre-commit hooks for a while. Make this explicit (drops 3.5/3.6 support for generated projects)
  • Syncs/updates pre-commit hooks to the versions used by saltstack/salt@master itself (or the most recent ones supported by Python 3.7, depending on declared version support)
  • Bumps the workflow versions
  • Doesn't create an apache license if other was specified
  • Adds functional tests skeleton
  • fixes a race condition in the pylint pre-commit hook
  • adds (minion|master)_opts unit test fixtures

Fixes: #34
Fixes: #35
Fixes: #43

The first commit now works without issues again.

@lkubb lkubb changed the title Updates and fixes Updates, fixes, parametrize versions Nov 13, 2023
3.5 and 3.6 have been EOL for a long time and are not compatible
with the current pre-commit hooks
* asottile/blacken-docs has been moved to adamchainz/blacken-docs
* click<8.1.0 is only required for old versions of black
@lkubb lkubb force-pushed the fixes-improvements branch 2 times, most recently from d53f1dd to 0ce23a1 Compare November 14, 2023 02:51
python_requires should have been bumped in 2.3.0
and rely on pylint's inbuilt parallelism
@lkubb lkubb mentioned this pull request Nov 15, 2023
@lkubb lkubb requested a review from s0undt3ch December 22, 2023 10:19
@s0undt3ch s0undt3ch merged commit 09e0933 into saltstack:main Dec 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pylint pre-commit hook race condition Functional test skeleton missing Requirement files missing
2 participants