Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean up salt.utils for using 2018.3.3 #1182

Merged
merged 5 commits into from Oct 29, 2018

Conversation

Projects
None yet
2 participants
@gtmanfred
Copy link
Contributor

commented Oct 26, 2018

No description provided.

@gtmanfred gtmanfred requested review from Ch3LL and rallytime as code owners Oct 26, 2018

@rallytime
Copy link
Contributor

left a comment

Nice! One request from me. :)

Show resolved Hide resolved _modules/pip.py Outdated
@rallytime

This comment has been minimized.

Copy link
Contributor

commented Oct 26, 2018

Fixes #903

@gtmanfred gtmanfred force-pushed the gtmanfred:2018.3 branch from e1b96ee to 5c81ae6 Oct 26, 2018

@gtmanfred gtmanfred force-pushed the gtmanfred:2018.3 branch from 5c81ae6 to 1cbd9bb Oct 26, 2018

@rallytime

This comment has been minimized.

Copy link
Contributor

commented Oct 26, 2018

@gtmanfred Looks like some of the tests are unhappy here.

@gtmanfred

This comment has been minimized.

Copy link
Contributor Author

commented Oct 26, 2018

yup, looks like the locale stuff is broken in 2018.3.3 for opensuse and debian/ubuntu

@gtmanfred

This comment has been minimized.

Copy link
Contributor Author

commented Oct 26, 2018

yup, one of them is going to have to be fixed when we switch over to using the branchs to bootstrap instead of stable releases.

saltstack/salt#50259

@rallytime

This comment has been minimized.

Copy link
Contributor

commented Oct 29, 2018

@gtmanfred Hrm, the ubuntu/debian tests are still having a rough time with this one. Can you take another look?

gtmanfred added some commits Oct 29, 2018

@gtmanfred gtmanfred added the passed label Oct 29, 2018

@gtmanfred gtmanfred merged commit 77e6aaa into saltstack:2018.3 Oct 29, 2018

3 checks passed

WIP Ready for review
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.