Adding ec2 profile data to be able to change them dynamically #1194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
https://github.com/saltstack/release-mgmt/pull/484 is the issue in release-mgmt repo. |
rallytime
reviewed
Nov 2, 2018
There was a problem hiding this comment.
This looks good to me, but I haven't worked on the cloud tests in ages. I think @Ch3LL or @gtmanfred should have a look here as well.
Commenting instead of approving so the bot doesn't merge this in without approval from others. :)
gtmanfred
approved these changes
Nov 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Profile overrides so that we can pass it in as pillar data through kitchen. We were doing the provider I figured I would add profile as well. Instead of hard coding it, we can change it dynamically via the Release-Mgmt Jenkins Cloud test states.