Skip to content

Commit

Permalink
Fix erroneous report on newline code
Browse files Browse the repository at this point in the history
  • Loading branch information
twangboy committed Jul 5, 2016
1 parent 75b6ed1 commit 2479b53
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions salt/states/file.py
Original file line number Diff line number Diff line change
Expand Up @@ -3519,6 +3519,7 @@ def append(name,

with salt.utils.fopen(name, 'rb') as fp_:
slines = fp_.readlines()
slines = [item.rstrip() for item in slines]

This comment has been minimized.

Copy link
@sjorge

sjorge Aug 2, 2016

Contributor

I think this line is causing #35121, the line that is marked as change has a whitespace at the end.

This comment has been minimized.

Copy link
@lorengordon

lorengordon Aug 2, 2016

Contributor

It's also kind of a hard way to do this, I think. fp_.read().splitlines() should accomplish the same thing, no?


append_lines = []
try:
Expand Down

0 comments on commit 2479b53

Please sign in to comment.