Skip to content

Commit

Permalink
Allow the minion test daemons a couple of tries to connect to the mas…
Browse files Browse the repository at this point in the history
…ter (#37150)

When running the tests with the tcp transport, we are not as forgiving
with the minion connection process as we are in ZMQ. In ZMQ, we attempt
to connect to the master. If it isn't up yet, we wait and try again. In
TCP, we try to connect to the master once, realize it's not up (because
the master process takes longer to spin up than the minions) and crash
and bail out.

This just gives the master a little more time to come up by having the
minions try to connect a couple more times.
  • Loading branch information
Nicole Thomas committed Oct 21, 2016
1 parent ec7ad9e commit 2bc5ded
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 0 deletions.
5 changes: 5 additions & 0 deletions tests/integration/files/conf/minion
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,11 @@ log_file: minion
#loop_interval: 0.05
config_dir: /tmp/salt-tests-tmpdir

# Give the minion extra attempts to find the master
# This is especially needed for the TCP tests as we
# wait for the master to come up in 2016.3. See #35489.
master_tries: 5

# module extension
test.foo: baz
hosts.file: /tmp/salt-tests-tmpdir/hosts
Expand Down
5 changes: 5 additions & 0 deletions tests/integration/files/conf/sub_minion
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,11 @@ sock_dir: sub_minion_sock
open_mode: True
log_file: minion

# Give the minion extra attempts to find the master
# This is especially needed for the TCP tests as we
# wait for the master to come up in 2016.3. See #35489.
master_tries: 5

# module extension
test.foo: baz
hosts.file: /tmp/salt-tests-tmpdir/hosts
Expand Down

0 comments on commit 2bc5ded

Please sign in to comment.