Skip to content

Commit

Permalink
include all ips in public_ips or private_ips
Browse files Browse the repository at this point in the history
  • Loading branch information
gtmanfred committed Feb 11, 2016
1 parent b2e8202 commit 47ecb7a
Showing 1 changed file with 8 additions and 16 deletions.
24 changes: 8 additions & 16 deletions salt/utils/openstack/nova.py
Original file line number Diff line number Diff line change
Expand Up @@ -139,22 +139,14 @@ def __init__(self, name, server, password=None):
'access_ip': server['accessIPv4']
}

if 'addresses' in server:
if 'public' in server['addresses']:
self.public_ips = [
ip['addr'] for ip in server['addresses']['public']
]
else:
self.public_ips = []

if 'private' in server['addresses']:
self.private_ips = [
ip['addr'] for ip in server['addresses']['private']
]
else:
self.private_ips = []

self.addresses = server['addresses']
self.addresses = server.get('addresses', {})
self.public_ips, self.private_ips = [], []
for network in self.addresses.values():
for addr in network:
if salt.utils.cloud.is_public_ip(addr['addr']):
self.public_ips.append(addr['addr'])
else:
self.private_ips.append(addr['addr'])

if password:
self.extra['password'] = password
Expand Down

0 comments on commit 47ecb7a

Please sign in to comment.