Merge pull request #39426 from morganwillcock/dism

win_dism: Return failure when package path does not exist

salt/states/win_dism.py

@@ -17,6 +17,7 @@
 
 # Import python libs
 import logging
+import os
 
 # Import salt libs
 import salt.utils
@@ -319,6 +320,15 @@ def package_installed(name,
            'comment': '',
            'changes': {}}
 
+    # Fail if using a non-existent package path
+    if '~' not in name and not os.path.exists(name):
+        if __opts__['test']:
+            ret['result'] = None
+        else:
+            ret['result'] = False
+        ret['comment'] = 'Package path {0} does not exist'.format(name)
+        return ret
+
     old = __salt__['dism.installed_packages']()
 
     # Get package info so we can see if it's already installed
@@ -387,6 +397,15 @@ def package_removed(name, image=None, restart=False):
            'comment': '',
            'changes': {}}
 
+    # Fail if using a non-existent package path
+    if '~' not in name and not os.path.exists(name):
+        if __opts__['test']:
+            ret['result'] = None
+        else:
+            ret['result'] = False
+        ret['comment'] = 'Package path {0} does not exist'.format(name)
+        return ret
+
     old = __salt__['dism.installed_packages']()
 
     # Get package info so we can see if it's already removed