saltutil.find_job is not compatible with multithreading

[olliewalsh]

saltuil.find_job strips out any jobs with the currently running pid: https://github.com/saltstack/salt/blob/0.17/salt/modules/saltutil.py#L401

This will remove ALL jobs for a multithreaded minion as they all have the same pid.

It will also fail to clean up the proc files for any complete jobs as it will not detect that the job has completed (it checks that the pid still exists).

[basepi]

Tom says we're going to disable multithreaded minions on *nix systems.

That said, this may be an issue on windows.

[olliewalsh]

Yea, I'm referring to the windows minion. It's related to #10523 - Fixing the thread blocking issue alone isn't going to resolve the windows timeout issue - but fix this too and the windows minion should work reasonably well (thread safety issues aside).