-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
state for network.system fails #11164
Comments
Thanks for the report, we'll investigate. Just FYI, the Debian/Ubuntu network support is very new (has only been out for the 2014.1.0 release) and may still have some bugs to work out. |
I am fully aware that it is still listed as being new and not at all mature. It is just a feature I have been waiting for, and thus wanted to test it right away, when it was introduced. |
Awesome! We love people who are willing to test new features! Just wanted to make sure you were aware. =) |
No problem. Let me know if I can do anything to help debug the problem. |
Will check this out. |
Found the cause. I'm an idiot :) the network.system bit didn't get finished. Looking at finishing it now. |
@drzero42 Would you be able to test the latest develop branch and see if the issue was resolved? |
@garethgreenaway Pull request #11401 has resolved this issue on my minions. |
Awesome! |
Sorry for the delay. I have now tested and it partially fixed the problem. Now I get this output:
It is true that /etc/default/networking. This file is not present on any of the Ubuntu 12.04 systems that I have checked. Perhaps the way to configure networking on Debian isn't exactly the same as on Ubuntu? |
Thanks. Will spin up an ubuntu and test. On March 25, 2014 6:31:49 AM PDT, Anders Bruun Olsen notifications@github.com wrote:
Sent from my Android phone with K-9 Mail. Please excuse my brevity. |
Looks like Ubuntu moved away from having /etc/default/networking, looking into what it was replaced with. |
No replacement for /etc/default/networking so when networking is disabled I'm disabling networking related services, eg. NetworkManager and networking. |
Merged into latest develop. @drzero42 Can you test again? Thanks! |
It works now. Although it creates /etc/default/networking, which is kind of pointless on an Ubuntu system. Should default not be to NOT create it, if it isn't there? |
Older Ubuntu system which are still supported still use that file. Its benign on the newer systems. On March 27, 2014 2:01:47 AM PDT, Anders Bruun Olsen notifications@github.com wrote:
Sent from my Android phone with K-9 Mail. Please excuse my brevity. |
Fair enough. I just figured that if a system uses /etc/default/networking, it would exist already when salt is run. Meaning that a default of not creating it, if it does not exist, seems smarter to me. But since it is indeed benign, I won't push the issue :) |
True. Going to look at this more, having files left over that aren't used isn't good practice either. |
@garethgreenaway |
I could template these out myself, but this is a major blocker for me. |
Can chat with some folks tomorrow and see if they can make there way into 2014.1.4 though it sounds like Helium isn't far off. |
@westurner #11522 made it into 2014.1.3, #11401 should make it into 2013.1.4. |
@garethgreenaway Thanks as always for your great work here! The release concerns aside, is this issue ready to be closed? |
@cachedout Should be ready to be closed. The original issue was fixed as reported byt @drzero42 and the issue of straggling files was fixed as well. |
@garethgreenaway Thanks for your quick response here. I'll go ahead and close this. If there are lingering concerns from anybody, please feel free to leave a comment on this issue and we can re-open it if necessary. Thanks all! |
network.system doesn't fail, but runs every time.
With this:
I have this output with every invocation:
Afterwards:
|
Thanks @garethgreenaway! |
In debian_ip, I will finish up patches to add |
I just tried out networking in states with Salt 2014.1.5. /etc/default/networking got created on Ubuntu 12.04, which it shouldn't be. Also gateway does not get set, making network states useless on Ubuntu still. Should I create a new issue for this, or should this issue be reopened? |
@drzero42 alot of the fixes have gone into develop and should be in the Helium release. If possible could you test develop and see if your issue is resolved? |
@drzero42 @garethgreenaway |
@timwsuqld can you paste cfg that causes the error, |
My State
Docs suggest (and it works on Centos machines) that I can define gateway and gatewaydev here. Doing so doesn't give me a default route under Ubuntu. Debug output
Not the best solution, but I currently have a workaround in my network.managed section to detect the gateway interface and apply an extra gateway option. This adds the correct gateway line to /etc/network/interfaces so that I do get a gateway route. |
I have the same problem on
salt runs fine but nothing actually happens and I can't see any entries into |
@cachedout @westurner Can we have someone respond or reopen this issue please? |
@timwsuqld @jgmchan Apologies. Missed your message back in August. I'll spin up an Ubuntu machine and test this out. |
@garethgreenaway Thanks. I probably should have done an @ mention back then. |
@timwsuqld no worries 😀 |
@timwsuqld @jgmchan Apologies for the delay in responding on this one. I remember dealing with this before and the root of the issue was the major differences with how networking is handled on Debian based machines vs. Red Hat machines. On RH machines the gateway is definable in a separate location than the interfaces, whereas on Debian machines it's defined with the interfaces. This gets tricky when you're trying to manage things like the gateway without managing the interface as well. Because of this the network.system state module function works quite differently on a Debian based machine vs. a Red Hat based machine. For managing the gateway I'd recommend using the network.managed or the network.routes state module functions. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. If this issue is closed prematurely, please leave a comment and we will gladly reopen the issue. |
I am testing out network management in Salt 2014.1.0 on Ubuntu 12.04 machines. I have pretty much just grabbed the examples from the documentation:
The system stanza fails with this traceback:
The text was updated successfully, but these errors were encountered: