Add splay option to schedule function

[roflmao]

An option called ‘splay’ can add a random configurable lag to this check-in time, to further balance out check-in frequency for ex schedule of a state.highstate in the minions.

[cachedout]

This is a good idea and shouldn't be terribly difficult to implement. I'll approve it for a future release. Thanks for the suggestion!

[rallytime]

Thanks for the work here @garethgreenaway!

@roflmao can you test with the above PR - we'd love to get this one closed out if it's working for you!

[rallytime]

I'm going to close this since we haven't heard anything for a bit here. If anyone has any related problems with this feature, leave a comment and we will be happy to re-open the issue.

[hal58th]

I found an issue with either documentation or code, depending on how you look at it.
The "splay" option requires the "seconds" option be used. I found this issue because I have minutes in my schedule, but seconds is not defined. This can be confusing as I want to schedule a job every 30 minutes with a splay of 30 seconds, or even 120 seconds. Which brings me to my next issue.

"splay" may work within a minute (splay of 10 means 0-10 seconds within that minute) or it can mean splay of range (splay of 10 means 10 seconds before or after job should run). A splay of more than 60 does not throw an error, so it makes figuring this out difficult without looking into the code. According to the documentation, it seems to be the first answer.

[garethgreenaway]

This should be fixed all branches, there was another issue that for using splay if seconds wasn't defined. Let me dig up the pull request and reference it here.

Update: #18484

[hal58th]

I should have said that this is version 2014.7.0 main release.
On Jan 15, 2015 4:22 PM, "garethgreenaway" notifications@github.com wrote:

This should be fixed all branches, there was another issue that for
using splay if seconds wasn't defined. Let me dig up the pull request and
reference it here.

—
Reply to this email directly or view it on GitHub
#11917 (comment).