2014.1.2: setup.py assumes zmq present

[mafrosis]

Looks like the latest 2014.1.2 assumes the presence of zmq for some freezer related code. This prevents it installing here, since I don't have zmq (HAS_ZMQ is False).

https://github.com/saltstack/salt/blob/v2014.1.2/setup.py#L516

If I swap lines 516 and 517 then the install works as expected.

[holmboe]

I am seeing this as well.

nn@wink:~/code/pkg-python/pypi-cache git:master$ ./refresh_downloads.sh salt-requirements.txt
>>>>>>>> Processing salt-requirements.txt

Downloading/unpacking salt==2014.1.2 (from -r salt-requirements.txt (line 1))
  Downloading salt-2014.1.2.tar.gz (2.8MB): 2.8MB downloaded
Saved ./salt-pypi/salt-2014.1.2.tar.gz
Running setup.py egg_info for package salt
  2014.1.2
  Traceback (most recent call last):
    File "<string>", line 16, in <module>
    File "/home/nn/venvs/pip2pi/build/salt/setup.py", line 516, in <module>
      if hasattr(zmq, 'pyzmq_version_info'):
  NameError: name 'zmq' is not defined
  Complete output from command python setup.py egg_info:
  2014.1.2

Traceback (most recent call last):

  File "<string>", line 16, in <module>

  File "/home/nn/venvs/pip2pi/build/salt/setup.py", line 516, in <module>

    if hasattr(zmq, 'pyzmq_version_info'):

NameError: name 'zmq' is not defined

----------------------------------------
Command python setup.py egg_info failed with error code 1 in /home/nn/venvs/pip2pi/build/salt
Storing complete log in /home/nn/.pip/pip.log
Traceback (most recent call last):
  File "/home/nn/profile/bin/pip2pi", line 8, in <module>
    load_entry_point('pip2pi==0.6.2', 'console_scripts', 'pip2pi')()
  File "/home/nn/venvs/pip2pi/local/lib/python2.7/site-packages/libpip2pi/commands.py", line 333, in pip2pi
    res = pip2tgz([argv[0], working_dir] + pip_packages)
  File "/home/nn/venvs/pip2pi/local/lib/python2.7/site-packages/libpip2pi/commands.py", line 55, in maintain_cwd_helper
    return f(*args, **kwargs)
  File "/home/nn/venvs/pip2pi/local/lib/python2.7/site-packages/libpip2pi/commands.py", line 242, in pip2tgz
    pip_run_command(['install', '-d', outdir] + argv[2:])
  File "/home/nn/venvs/pip2pi/local/lib/python2.7/site-packages/libpip2pi/commands.py", line 135, in pip_run_command
    %(res, pip_args))
libpip2pi.commands.PipError: pip failed with status 1 while running: ['install', '-d', '/home/nn/code/pkg-python/pypi-cache/salt-pypi', '-r', 'salt-requirements.txt']

>>>>>>>> Processed requirements for 1 packages:

  salt
nn@wink:~/code/pkg-python/pypi-cache git:master$ 

[rallytime]

Good catch @mafrosis and @holmboe - I'm not super familiar with how setup.py works, and there have been a lot of changes to it on the develop branch, so I'm hesitant to just switch those two lines on the 2014.1 branch.

@s0undt3ch - could you take a look at this issue since you're pretty involved in the setup file?

[s0undt3ch]

This is fixed in develop I believe, so, its a missing cherry pick on the 2014.1 branch.

I'll take care of this in 2-3 hours.

Pedro Algarvio @ Phone

----- Reply message -----
From: "Nicole Thomas" notifications@github.com
To: "saltstack/salt" salt@noreply.github.com
Cc: "Pedro Algarvio" pedro@algarvio.me
Subject: [salt] 2014.1.2: setup.py assumes zmq present (#12031)
Date: Thu, Apr 17, 2014 20:06
Good catch @mafrosis and @holmboe - I'm not super familiar with how setup.py works, and there have been a lot of changes to it on the develop branch, so I'm hesitant to just switch those two lines on the 2014.1 branch.

@s0undt3ch - could you take a look at this issue since you're pretty involved in the setup file?

—
Reply to this email directly or view it on GitHub.

[s0undt3ch]

#12093 should fix this.

[s0undt3ch]

For those what need it, e86039a, that's the commit to use to patch.

[ghost]

Thanks @s0undt3ch :)

[s0undt3ch]

Anytime @rallytime!

[abemusic]

Also seeing this with 2014.1.3. Is the preferred workaround to use 2014.1.1 until PyPI is updated with a fixed 2014.1.3?

[basepi]

If you just apply the patch that @s0undt3ch mentioned above, you can then freeze 2014.1.3.

Not sure if we'll be uploading a new 2014.1.3 since it would require a new tag. We may just cut a fairly quick 2014.1.4.