master_tops appears broken in 2014.1.5

[mgwilliams]

On 2014.1.5, custom tops modules (located in {extension_modules}/tops) are loaded (__virtual__ function is called), but not utilized (top function is not invoked).

The tops module (/srv/salt/modules/tops/test.py):

import logging


log = logging.getLogger(__name__)


def __virtual__():
    log.warning('test loaded')
    return 'test'


def top(**kwargs):
    log.warning('test top')
    return {'base': ['test']}

master config:

extension_modules: /srv/salt/modules/
master_tops:
  test: True

salt-call state.show_top

On 2014.1.4:

local:
    ----------
    base:
        - test

On 2014.1.5:

local:
    ----------

[thatch45]

Marked as High Severity, we will look into this ASAP

[cro]

@thatch45 ref #13686

[pass-by-value]

I did a git bisect and found that this was introduced by 76fdca0

Looking to see if the changes mentioned by #13686 can get us back to the expected behavior.

[cachedout]

We should get regression testing here ASAP.

On Tue, Jun 24, 2014 at 2:47 PM, Aditya Kulkarni notifications@github.com
wrote:

I did a git bisect and found that this was introduced by 76fdca0
76fdca0

Looking to see if the changes mentioned by #13686
#13686 can get us back to the
expected behavior.

—
Reply to this email directly or view it on GitHub
#13673 (comment).

[pass-by-value]

@cachedout Good idea! I'll add a regression test to it.

[pass-by-value]

I've added #13762 and #13730 to test this

[pass-by-value]

Also added #13764

[pass-by-value]

#13807 is added so that tests on 2014.1 branch are passing

[rallytime]

Awesome!

[pass-by-value]

#13940

[basepi]

This is finally fixed! The new test is passing and the fix is in both 2014.1 and develop, and will be in 2014.1.6.