New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stacktrace using new listen/listen_in feature #13726

Closed
ryan-lane opened this Issue Jun 25, 2014 · 7 comments

Comments

Projects
None yet
3 participants
@ryan-lane
Contributor

ryan-lane commented Jun 25, 2014

[ERROR   ] An un-handled exception was caught by salt's global exception handler:
KeyError: 'file_|-Ensure statsd supervisor configuration exists_|-/etc/supervisor/conf.d/statsd.conf_|-managed'
Traceback (most recent call last):
  File "/usr/bin/salt-call", line 11, in <module>
    salt_call()
  File "/usr/lib/python2.7/dist-packages/salt/scripts.py", line 128, in salt_call
    client.run()
  File "/usr/lib/python2.7/dist-packages/salt/cli/__init__.py", line 398, in run
    caller.run()
  File "/usr/lib/python2.7/dist-packages/salt/cli/caller.py", line 186, in run
    ret = self.call()
  File "/usr/lib/python2.7/dist-packages/salt/cli/caller.py", line 91, in call
    ret['return'] = func(*args, **kwargs)
  File "/usr/lib/python2.7/dist-packages/salt/modules/state.py", line 287, in highstate
    whitelist=kwargs.get('whitelist')
  File "/usr/lib/python2.7/dist-packages/salt/state.py", line 2768, in call_highstate
    return self.state.call_high(high)
  File "/usr/lib/python2.7/dist-packages/salt/state.py", line 1904, in call_high
    ret = self.call_listen(chunks, ret)
  File "/usr/lib/python2.7/dist-packages/salt/state.py", line 1869, in call_listen
    if running[to_tag]['changes']:
@thatch45

This comment has been minimized.

Member

thatch45 commented Jun 25, 2014

Can you show me your sls file?

thatch45 added a commit that referenced this issue Jun 25, 2014

@thatch45

This comment has been minimized.

Member

thatch45 commented Jun 25, 2014

I sent up a fix, but I would like to be able to reproduce it, we might be missing a case.

@thatch45 thatch45 added Bug labels Jun 25, 2014

@thatch45 thatch45 added this to the ww27 milestone Jun 25, 2014

@thatch45 thatch45 self-assigned this Jun 25, 2014

@ryan-lane

This comment has been minimized.

Contributor

ryan-lane commented Jun 25, 2014

Ensure statsd supervisor configuration exists:
  file.managed:
    - name: /etc/supervisor/conf.d/statsd.conf
    - source: salt://base/statsd/supervisor.conf
    - listen_in:
      - cmd: supervisorctl reload

Conditionally reload supervisor:
  cmd.wait:
    - name: supervisorctl reload
@thatch45

This comment has been minimized.

Member

thatch45 commented Jun 25, 2014

thanks, I am trying to reproduce this and get a better view of the data

@cachedout

This comment has been minimized.

Contributor

cachedout commented Jul 25, 2014

For what it's worth, the sample provided by @ryan-lane works for me both in current develop and develop with the commit by @thatch45 removed. However, it does stacktrace in 2014.1.7.

I recommend that we consider this issue resolved unless there is further research to be done, as this should work in the RC, etc, etc.

@cachedout

This comment has been minimized.

Contributor

cachedout commented Jul 25, 2014

Marked as "Fixed Pending Verification"

@cachedout

This comment has been minimized.

Contributor

cachedout commented Aug 4, 2014

I'm going to go ahead and close this since there hasn't been any reply. If this remains a problem with the patch by @thatch45 applied then we can re-open.

@cachedout cachedout closed this Aug 4, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment