Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arch: systemd service file does not start salt-master (2014.7.0rc6) #16912

Closed
cro opened this issue Oct 26, 2014 · 18 comments
Closed

Arch: systemd service file does not start salt-master (2014.7.0rc6) #16912

cro opened this issue Oct 26, 2014 · 18 comments
Labels
Bug broken, incorrect, or confusing behavior fixed-pls-verify fix is linked, bug author to confirm fix Regression The issue is a bug that breaks functionality known to work in previous releases. severity-medium 3rd level, incorrect or bad functionality, confusing and lacks a work around
Milestone

Comments

@cro
Copy link
Contributor

cro commented Oct 26, 2014

While experimenting with Arch this evening I discovered that for RC6, systemctl start salt-master will stick. Changing the Type in the .service file from notify to simple will resolve this, but I am pretty sure this is not the 'right' solution.

@cro cro added Bug broken, incorrect, or confusing behavior severity-medium 3rd level, incorrect or bad functionality, confusing and lacks a work around Regression The issue is a bug that breaks functionality known to work in previous releases. labels Oct 26, 2014
@techhat
Copy link
Contributor

techhat commented Oct 26, 2014

I've seen this value flip-flop a lot on Arch. @terminalmage and @gtmanfred, what is the official word on this?

@gtmanfred
Copy link
Contributor

This has to be solved in the process management, it it changed again since I fixed it, then it probably broke. I will take a look tomorrow

@gtmanfred
Copy link
Contributor

It should absolutely be notify, please make sure you have python2-systemd installed

@s0undt3ch
Copy link
Member

On October 26, 2014 3:21:23 AM GMT, Daniel Wallace notifications@github.com wrote:

It should absolutely be notify, please make sure you have
python2-systemd installed


Reply to this email directly or view it on GitHub:
#16912 (comment)

So python2-systemd should probably also be installed by the bootstrap script right?
Pedro Algarvio @ Phone

@terminalmage
Copy link
Contributor

Yeah, if installed via git then this dependency would not be installed automatically, so the bootstrap script would need to handle this.

Is that how @cro installed it?

@cro
Copy link
Contributor Author

cro commented Oct 26, 2014

Yes, I installed via bootstrap.

C. R. Oldham, Engineer, SaltStack
cr@saltstack.com

On Oct 26, 2014, at 07:24, Erik Johnson notifications@github.com wrote:

Yeah, if installed via git then this dependency would not be installed automatically, so the bootstrap script would need to handle this.

Is that now @cro installed it?


Reply to this email directly or view it on GitHub.

@s0undt3ch
Copy link
Member

OK. I'll get a fix fix this today

@rallytime
Copy link
Contributor

Thanks for the the fix @s0undt3ch! I just tested this and it is fixed. Do we need to get this change/update the bootstrap script for the next RC?

@rallytime rallytime added the fixed-pls-verify fix is linked, bug author to confirm fix label Oct 27, 2014
@rallytime
Copy link
Contributor

@s0undt3ch I was asked by @terminalmage to check this in Fedora 20 as well, since it also uses systemd and the salt-master service is also hanging for Fedora 20.

@rallytime rallytime removed the fixed-pls-verify fix is linked, bug author to confirm fix label Oct 27, 2014
@terminalmage
Copy link
Contributor

Yeah, the idea being that there is a separate function to install fedora deps. Though whether or not to test this could be obviated by looking at the code.

/me looks...

@terminalmage
Copy link
Contributor

@s0undt3ch
Copy link
Member

I'll have to fix Fedora and a any other systemd distro...

@basepi basepi added this to the Approved milestone Oct 27, 2014
@s0undt3ch
Copy link
Member

The new bootstrap script (already submitted PR's) now install the python bindings of systemd on git installs(Arch and Fedora)

@rallytime
Copy link
Contributor

Thanks @s0undt3ch! :)

@terminalmage
Copy link
Contributor

@s0undt3ch FTW!

@cachedout
Copy link
Contributor

@s0undt3ch Could you link the PRs so we can close this when they're merged. Thanks!

@cachedout cachedout added the fixed-pls-verify fix is linked, bug author to confirm fix label Oct 28, 2014
@s0undt3ch
Copy link
Member

Nice!

@rallytime
Copy link
Contributor

I've confirmed that this has been fixed on Arch and Fedora now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug broken, incorrect, or confusing behavior fixed-pls-verify fix is linked, bug author to confirm fix Regression The issue is a bug that breaks functionality known to work in previous releases. severity-medium 3rd level, incorrect or bad functionality, confusing and lacks a work around
Projects
None yet
Development

No branches or pull requests

8 participants