Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

external_auth to limit arguments sent to salt modules #20255

Closed
arthurzenika opened this issue Jan 30, 2015 · 5 comments
Closed

external_auth to limit arguments sent to salt modules #20255

arthurzenika opened this issue Jan 30, 2015 · 5 comments
Labels
Feature new functionality including changes to functionality and code refactors, etc.
Milestone

Comments

@arthurzenika
Copy link
Contributor

This is a feature request for a finer ACL mechanism in external_auth.

I would like to limit the scope of certain modules, for example, allowing cmd.run but only for certain commands :

external_auth:
  pam:
    saltdev:
         - cmd.run:
             - echo.*

or so that some users can apply only certain states :

external_auth:
  pam:
    saltdev:
         - state.sls:
             - deploy

Right now, the only way to do this in salt (that I can think of) is to add a module that only does that sub part and allow it in external_auth. If anyone can think of another way with the existing code, please suggest it here!

@arthurzenika
Copy link
Contributor Author

Of course with the cmd.run example, one should be careful about the following scenario cmd.run "echo hello; cat /etc/password" scenario.

@rallytime rallytime added the Feature new functionality including changes to functionality and code refactors, etc. label Jan 30, 2015
@rallytime rallytime added this to the Approved milestone Jan 30, 2015
@rallytime
Copy link
Contributor

@arthurlogilab That's a great idea! Approved as a feature request.

@danlsgiga
Copy link
Contributor

+1

@whiteinge
Copy link
Contributor

This was implemented in #29153. Docs in #33847.

@rallytime
Copy link
Contributor

The feature added in #29153 is available in the 2016.3.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature new functionality including changes to functionality and code refactors, etc.
Projects
None yet
Development

No branches or pull requests

4 participants