-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ACL limit args #29153
Merged
cachedout
merged 9 commits into
saltstack:develop
from
DSRCorporation:features/3077_acl_limit_args
Nov 25, 2015
Merged
ACL limit args #29153
cachedout
merged 9 commits into
saltstack:develop
from
DSRCorporation:features/3077_acl_limit_args
Nov 25, 2015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Great! This might take a little time to review but I will try and get it in today or tomorrow. |
@cachedout thank you! |
I'll recheck tomorrow. The tests passed locally on my dev box. |
The method logic was changed in mock-1.1.0. This mades the use of the method compatible with both <1.1.0 and >=1.1.0
cachedout
pushed a commit
that referenced
this pull request
Nov 25, 2015
Looks really good! Merged. |
@cachedout thank you! |
This was referenced Jun 8, 2016
This is a really awesome feature! Thanks a lot! |
rallytime
pushed a commit
to rallytime/salt
that referenced
this pull request
Jun 9, 2016
This adds documentation for the addition in saltstack#29153.
can we get one example for package |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows to limit function arguments values with 'external_auth' in master config.
The feature is implemented for #3077